Move UninitializedFieldError to derive_builder #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UninitializedFieldError is part of the runtime API of derive_builder, not part of its compile-time macro machinery. Exporting it from the derive_builder_core crate caused downstream crates to unnecessarily import all of derive_builder_core, rather than only importing it via the proc-macro crate at compile-time. Fixes #201
|
@andy128k any idea why this fails when the original PR adding the test succeeds? I'm very unfamiliar with |
This is causing a CI failure which blocks fixing no_std support
|
Filed an issue to bring back the removed test, so proceeding to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UninitializedFieldError is part of the runtime API of derive_builder,
not part of its compile-time macro machinery. Exporting it from the
derive_builder_core crate caused downstream crates to unnecessarily
import all of derive_builder_core, rather than only importing it via
the proc-macro crate at compile-time.
Fixes #201