Shrink derive_builder_core's public API #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only crate to depend on derive_builder_core is derive_builder. While it's useful that derive_builder_core is _able_ to export more than the derive function in the future, shrinking the API surface to be only the one function now means that adding builder features won't force semver bumps due to changes in the public-facing intermediate structs. Because the structs are no longer public, doc-tests for those structs no longer compile. These are now ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only crate to depend on derive_builder_core is derive_builder. While it's useful that derive_builder_core is able to export more than the derive function in the future, shrinking the API surface to be only the one function now means that adding builder features won't force semver bumps due to changes in the public-facing intermediate structs.
Because the structs are no longer public, doc-tests for those structs no longer compile. These are now ignored.