Remove skeptic #188
Merged
Remove skeptic #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complexity in the repo's tests have made it difficult for maintainers and contributors to work on the crate with confidence that they haven't caused regressions. `skeptic` was a major driver of that complexity, as it introduced the need for an additional piece of the test matrix and custom build scripts. That complexity was only testing a single example in the README, and that example is already covered by the examples/ directory. Removing skeptic simplifies the repo and the CI test pass with minimal reduction in test coverage.
|
@andy128k can you take a look at this and see if I've missed anything as far as 1) where |
|
@TedDriggs Probably whole module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complexity in the repo's tests have made it difficult for maintainers
and contributors to work on the crate with confidence that they haven't
caused regressions.
skepticwas a major driver of that complexity, asit introduced the need for an additional piece of the test matrix and
custom build scripts.
That complexity was only testing a single example in the README, and
that example is already covered by the examples/ directory. Removing
skeptic simplifies the repo and the CI test pass with minimal reduction
in test coverage.