Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darling: bump for minimal version compatibility #153

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

mathstuf
Copy link
Contributor

This allows -Z minimal-versions to be used in derive_builder-using
crates.


Needs a release of darling with TedDriggs/darling#83 included. Just making a guess at the version number it would use.

This allows `-Z minimal-versions` to be used in derive_builder-using
crates.
@TedDriggs
Copy link
Collaborator

Can you provide a link to this minimal-versions flag? I'm a bit confused and I'm not finding anything authoritative on Google.

@mathstuf
Copy link
Contributor Author

rust-lang/cargo#5657

@TedDriggs
Copy link
Collaborator

TedDriggs commented Oct 30, 2019

Ah, it took me a minute but I think I finally understand what's going on here.

  1. darling_core was using a function from syn@1.0.1, but just declared 1 as its dependency. This happened to work because it was valid to resolve that as the latest syn, which is what normally happened.
  2. This minimal-versions flag says to choose the oldest satisfactory version of the dependency, rather than the newest. This caused darling_core to break when the flag was set.
  3. The change in syn: bump minimum to 1.0.1 TedDriggs/darling#83 fixed that crate's dependencies, but now we need to republish darling_core with the fixed Cargo.toml, and then we need to republish this crate pointing to that dependency.

Did I get all that right?

Edit: I'll publish the darling crates as soon as CI passes, then we can re-run the Travis job for this PR.

@mathstuf
Copy link
Contributor Author

Yep, that sounds right.

@TedDriggs
Copy link
Collaborator

@mathstuf CI is now passing, but at the moment the PR is still marked "WIP". Is it ready to merge, or were there other changes you planned to make?

@mathstuf mathstuf changed the title WIP: darling: bump for minimal version compatibility darling: bump for minimal version compatibility Oct 30, 2019
@mathstuf
Copy link
Contributor Author

It was WIP because I was unsure of the version for the suitable darling release. Now unmarked. Thanks!

@TedDriggs TedDriggs merged commit 0765974 into colin-kiegel:master Oct 30, 2019
@mathstuf mathstuf deleted the minimal-versions-compat branch October 31, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants