Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update darling, quote, proc-macro2, syn #148

Merged
merged 2 commits into from
Sep 30, 2019

Conversation

spearman
Copy link
Contributor

@spearman spearman commented Sep 3, 2019

There were some changes in how syn handles paths/idents. I haven't actually written any procedural macros myself so somebody may want to look it over, but all tests were passed.

@TedDriggs
Copy link
Collaborator

Thanks for submitting this. Due to the increase in darling's strsim dependency, I'm going to need to make this be a minor version bump to maintain compatibility.

@kpcyrd
Copy link

kpcyrd commented Sep 26, 2019

I'm very interested in this patch too, is there any way I can help getting this landed?

@TedDriggs
Copy link
Collaborator

I'll take a look Monday and get the version bump done

This makes it possible to take the latest of darling, syn, and other
dependencies.
@TedDriggs TedDriggs merged commit 67c9c95 into colin-kiegel:master Sep 30, 2019
@azriel91
Copy link
Contributor

azriel91 commented Sep 30, 2019

@TedDriggs derive-builder-core was published, but the derive-builder crate itself hasn't. Wondering if that was a partial publishing error or something? 🙃

(am super keen to bump deps)

edit: ah yeap -- publishing needs a delay: #146

@TedDriggs
Copy link
Collaborator

@azriel91 sorry about that. I don't have my computer with me now, but it'll be live by 8am Pacific tomorrow

@TedDriggs
Copy link
Collaborator

@azriel91 it's now fixed. If you submit a PR adding a 10-second sleep between publishes, I'll happily merge it. (10s is arbitrary, but seemed to be enough for darling's script to start working again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants