Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylint complains that subclasses of ColumnBase leave __iter__() unimplemented #2612

Closed
jborman-exos opened this issue Aug 26, 2022 · 1 comment
Closed

Pylint complains that subclasses of ColumnBase leave __iter__() unimplemented #2612

jborman-exos opened this issue Aug 26, 2022 · 1 comment

Comments

@jborman-exos
Copy link

Related to the fix released for #2606, running pylint over a local subclass of ColumnBase raises the following:

Method '__iter__' is abstract in class 'ColumnBase' but is not overridden (abstract-method)

Raising NotimplementedError implies that a concrete class is meant to implement this abstract method. According to the python docs, if __iter__ is never to be implemented on a subclass of ColumnBase, then it should be set to None
coleifer added a commit that referenced this issue Aug 26, 2022
@coleifer
Fix pylint complaint, #2612
304e209
@coleifer
Copy link
Owner

No problem, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coleifer @jborman-exos