Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colcon returns with success when extension loading fails #637

Open
christianrauch opened this issue Apr 12, 2024 · 0 comments
Open

colcon returns with success when extension loading fails #637

christianrauch opened this issue Apr 12, 2024 · 0 comments

Comments

@christianrauch
Copy link

When an extension throws an exception during loading, a backtrace is shown but colcon continues:

try:
extension_type = load_extension_point(name, value, group)
except RuntimeError:
continue
except Exception as e: # noqa: F841
# catch exceptions raised when loading entry point
exc = traceback.format_exc()
logger.error(
'Exception loading extension '
f"'{group}.{name}': {e}\n{exc}")
# skip failing entry point, continue with next one
continue

That means, if an extension fails to load, colcon will return with exit code 0, indicating success. For automation, it would be more useful if colcon returns an exit code indicating an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant