Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring Framework 6.0.3 breaks Coherence annotation support #119

Closed
ghillert opened this issue Jan 18, 2023 · 1 comment
Closed

Spring Framework 6.0.3 breaks Coherence annotation support #119

ghillert opened this issue Jan 18, 2023 · 1 comment
Assignees
@ghillert
Labels
for: backport-to-3.3.x Marks an issue as a candidate for backport to 3.3.x Priority: Major Type: Defect
Milestone
4.0.0

Comments

@ghillert
Copy link
Contributor

ghillert commented Jan 18, 2023 •
edited

Starting with Spring Framework 6.0.3 (6.0.2 works fine) and 5.3.25, annotation processing of e.g. @PropertyExtractor is broken. Spring Framework fixed bug spring-projects/spring-framework#29685 that removed a work-around we were employing to provide support for e.g. repeatable @PropertyExtractor annotations.

Spring Framework issue spring-projects/spring-framework#26302 would seem to be possibly able to address the issue by adding support for @NonBinding annotations but it has been open for 2+ years.

We may most like need to refactor that support by providing a more Spring-like programming model. That would be most likely a more substantial breaking change.
@ghillert ghillert added this to the 4.0.0 milestone Jan 18, 2023
@ghillert ghillert self-assigned this Jan 18, 2023
@ghillert ghillert added the for: backport-to-3.3.x Marks an issue as a candidate for backport to 3.3.x label Mar 31, 2023
ghillert added a commit to ghillert/coherence-spring that referenced this issue Apr 1, 2023
@ghillert
coherence-communitygh-119 Fix Spring Framework 6.0.3 breaks Coherence…
952b7f1 
… annotation support

- Provide default ValueExtractors via ExtractorService
- Provide default Filters via FilterService
- Add custom logic to retrieve custom + annotated Filters & Extractors from the ApplicationContext
- Refactor common code into CoherenceAnnotationUtils
- All tests pass unchanged
ghillert added a commit to ghillert/coherence-spring that referenced this issue Apr 3, 2023
@ghillert
coherence-communitygh-119 Fix Spring Framework 6.0.3 breaks Coherence…
b4a3b8b 
… annotation support

- Provide default ValueExtractors via ExtractorService
- Provide default Filters via FilterService
- Add custom logic to retrieve custom + annotated Filters & Extractors from the ApplicationContext
- Refactor common code into CoherenceAnnotationUtils
- All tests pass unchanged
@ghillert
Copy link
Contributor Author

Fixed by b4a3b8b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghillert ghillert

Labels
for: backport-to-3.3.x Marks an issue as a candidate for backport to 3.3.x Priority: Major Type: Defect
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@ghillert