Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Waiting time for test running #65

Open
pateash opened this issue Feb 9, 2020 · 2 comments
Open

Fixing Waiting time for test running #65

pateash opened this issue Feb 9, 2020 · 2 comments
Assignees
@pateash
Labels
help-wanted Extra attention is needed test-changes

Comments

@pateash
Copy link
Contributor

pateash commented Feb 9, 2020

Currently, the test which takes more time or has async code
doesn't wait for it to complete and mark it as pass.

image

Here we have settimout(), which is just making to execute expect() statement and causing to pass anyway,
Is there a way to do something about it.

https://github.com/oclif/fancy-test
@pateash
Copy link
Contributor Author

pateash commented Feb 9, 2020

can we do something with done() or retry()
image

@pateash pateash self-assigned this Feb 9, 2020
@pateash pateash added help-wanted Extra attention is needed testing labels Feb 9, 2020
@pateash pateash mentioned this issue Feb 9, 2020
Closed
@pateash
Copy link
Contributor Author

pateash commented Feb 9, 2020 •
edited

its also there in bundlephobia test
image

commenting as it is breaking
#50
image

@pateash pateash removed the testing label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pateash pateash

Labels
help-wanted Extra attention is needed test-changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pateash