Resolve #39 -- Make default search more like Django admin #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 99.57% 99.15% -0.42%
==========================================
Files 7 7
Lines 233 238 +5
==========================================
+ Hits 232 236 +4
- Misses 1 2 +1
Continue to review full report at Codecov.
|
Different to before we now match search terms only if all bits match or the entire statement. The last part differs from the behavior in Django admin, which does not inlcude exact machtes of the entire search term inlcude spaces. Partially revert 07054b2
syphar
approved these changes
Mar 9, 2021
| field_select |= Q(**{field: word}) | ||
|
|
||
| select |= field_select | ||
| use_distinct = False |
There was a problem hiding this comment.
IMHO a comment about the source of this block would be helpful, right?
There was a problem hiding this comment.
Dang, I didn't see this comment, sorry.
|
(the test failure feels like it's not related to this change, but flaky, but I didn't check) I did a short manual test on our systems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different to before we now match search terms only if all
bits match or the entire statement. The last part differs
from the behavior in Django admin, which does not inlcude
exact machtes of the entire search term inlcude spaces.
Partially revert 07054b2