Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pre-commit hook definition to run codespell #1117

Merged
merged 1 commit into from
May 16, 2019

Conversation

marco-c
Copy link
Contributor

@marco-c marco-c commented May 15, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented May 15, 2019

Codecov Report

Merging #1117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1117   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files           4        4           
  Lines         727      727           
  Branches      106      106           
=======================================
  Hits          664      664           
  Misses         46       46           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2888c75...1b6e02b. Read the comment docs.

@larsoner
Copy link
Member

I have never used this before. I looked only briefly at the docs

https://pre-commit.com/

Is the purpose of adding the file to codespell's repo just to provide a template for other git repos that want to use codespell as a pre-commit hook? Or is there more to i?

@marco-c
Copy link
Contributor Author

marco-c commented May 16, 2019

Is the purpose of adding the file to codespell's repo just to provide a template for other git repos that want to use codespell as a pre-commit hook? Or is there more to i?

Yes, that's it. I've created a temporary repository to do it at https://github.com/marco-c/pre-commit-codespell, but I'm going to remove it if this PR is merged. Here's an example usage: mozilla/bugbug#411.

Here's another example of pre-commit hook definition, for black: https://github.com/python/black/blob/master/.pre-commit-hooks.yaml.

@larsoner larsoner merged commit bcb5b06 into codespell-project:master May 16, 2019
@larsoner
Copy link
Member

Great, thanks!

@asottile
Copy link
Contributor

Adding this to the website -- thanks all! pre-commit/pre-commit.com#237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants