Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add a means of indicating a "node" project #17

Open
mike-north opened this issue Sep 28, 2018 · 0 comments
Open

[Feature Request] Add a means of indicating a "node" project #17

mike-north opened this issue Sep 28, 2018 · 0 comments

Comments

@mike-north
Copy link
Contributor

Currently, when the template of a project cannot be inferred via a big stack of conditions, create-react-app is chosen as a default.

https://github.com/codesandbox-app/codesandbox-importers/blob/079f9528017b2a73739f42ba29571f9f049c8119/packages/import-utils/src/create-sandbox/index.ts#L64

Particularly with the new server-side evaluation support, this may not be a reasonable or safe default anymore. Perhaps node should be the new default, with create-react-app being only reasonable in the presence of react or cra as a (dev)dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant