Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getParameters method in define API requires file content to be a string in TypeScript #137

Open
juliannaroen opened this issue Aug 19, 2021 · 3 comments
Assignees

Comments

@juliannaroen
Copy link

juliannaroen commented Aug 19, 2021

The getParameters method currently requires the value under content (which is a property of a file) to be a string:

But in the docs, it's specified that content under package.json can be an object.

Either the documentation or the type signature on getParameters should be updated accordingly. I currently can't use an object in TS.

@juliannaroen
Copy link
Author

juliannaroen commented Aug 19, 2021

I made a demo of how the package.json key could be typed in this TS playground.

@sbinlondon
Copy link
Contributor

Thanks for opening the issue @juliannaroen! You're right, the docs are a bit wrong and we should update them. We're currently in the middle of rewriting the git importer into our Elixir server (instead of having it here as a standalone) and once we've done that we'll be completely rewriting some of the docs, especially the ones for the define endpoint.

In the meantime I'll try and make a small change to the docs to clarify what should be used now and let you know when I've done this. Hopefully next week.

@sbinlondon sbinlondon self-assigned this Aug 27, 2021
@gdostie
Copy link

gdostie commented Nov 16, 2022

Any progress on the define endpoint docs @sbinlondon? Would a PR containing @juliannaroen's proposal be accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants