Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posibility of a 2.2.4 release with updated axios #136

Open
evansrobert opened this issue Aug 12, 2021 · 2 comments
Open

posibility of a 2.2.4 release with updated axios #136

evansrobert opened this issue Aug 12, 2021 · 2 comments
Assignees

Comments

@evansrobert
Copy link

Hi, @CompuIves @sbinlondon,

Issue Description

I noticed that a vulnerability is introduced in codesandbox@2.2.3:
Vulnerability CVE-2020-28168 affects package axios (versions:<0.21.1): https://snyk.io/vuln/SNYK-JS-AXIOS-1038255
The above vulnerable package is referenced by codesandbox@2.2.3 via:
codesandbox@2.2.3 ➔ axios@0.18.1

Since codesandbox@2.2.3 (3,338 downloads per week) is referenced by 93 downstream projects (e.g., @patternfly/react-docs 4.21.35 (latest version), trafimage-maps 1.5.36 (latest version), @antv/gatsby-theme-antv 1.1.8 (latest version), storybook-addon-preview 2.1.2 (latest version), mobility-toolbox-js 1.3.5 (latest version)), the vulnerability CVE-2020-28168 can be propagated into these downstream projects and expose security threats to them via the following package dependency paths:
(1)@antv/gatsby-theme-antv@1.1.6 ➔ codesandbox@2.2.3 ➔ axios@0.18.1
(2) @pxwlab/katana@1.0.7 ➔ codesandbox@2.2.3 ➔ axios@0.18.1
......

If codesandbox@2.2.* removes the vulnerable package from the above version, then its fixed version can help downstream users decrease their pain.

Given the large number of downstream users, could you help update your package to remove the vulnerability from codesandbox@2.2.3 ?

Fixing suggestions

In codesandbox@2.2.4, maybe you can kindly try to perform the following upgrade(not crossing major version) :
axios ^0.18.1 ➔ ^0.21.1;

Note:
axios@0.21.1(>=0.21.1) has fixed the vulnerability CVE-2020-28168.

Thank you for your attention to this issue.

Best regards,
^_^

@sbinlondon
Copy link
Contributor

Hi @evansrobert thank you for raising this 🚀 We'll have a look at this upgrade and work on it if it makes sense for us. We're currently rewriting this service into our Elixir server so it actually won't be around much longer but if this is a quick fix then we can definitely do it 👍

@sbinlondon sbinlondon self-assigned this Aug 12, 2021
@evansrobert
Copy link
Author

@sbinlondon Thanks for your understanding and help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants