Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.23.1 breaks within selfhosted coder instance #6767

Open
1 of 2 tasks
TheZoker opened this issue Apr 21, 2024 · 4 comments
Open
1 of 2 tasks

4.23.1 breaks within selfhosted coder instance #6767

TheZoker opened this issue Apr 21, 2024 · 4 comments
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer

Comments

@TheZoker
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: Brave
  • Local OS: Windows 11
  • Remote OS: Coder.com
  • Remote Architecture:
  • code-server --version: 4.23.1

Steps to Reproduce

  1. Update code-server version from 4.23.0 to 4.23.1

Expected

Working

Actual

Not working

Logs

No response

Screenshot/Video

No response

Does this bug reproduce in native VS Code?

This cannot be tested in native VS Code

Does this bug reproduce in GitHub Codespaces?

No, this works as expected in GitHub Codespaces

Are you accessing code-server over a secure context?

  • I am using a secure context.

Notes

I upgraded code-server from 4.23.0 to 4.23.1 within my coder.com instance (using this module: https://registry.coder.com/modules/code-server).

When I now start my workspace, I get this error:

gzip: stdin: invalid compressed data--crc error
tar: Child returned status 1
tar: Error is not recoverable: exiting now
Failed to install code-server: Ubuntu 23.10
Installing v4.23.1 of the amd64 release from GitHub.
+ Reusing ~/.cache/code-server/code-server-4.23.1-linux-amd64.tar.gz
+ mkdir -p /tmp/code-server
+ mkdir -p /tmp/code-server/lib /tmp/code-server/bin
+ tar -C /tmp/code-server/lib -xzf ~/.cache/code-server/code-server-4.23.1-linux-amd64.tar.gz

When I downgrade again to 4.23.0 everything works fine.

@TheZoker TheZoker added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Apr 21, 2024
@matifali
Copy link
Contributor

This looks related to coder/coder#12790 (comment).
We fixed it by explicitly setting --host 127.0.0.1 in coder/modules#216

@TheZoker
Copy link
Author

Hmm I'm using version 1.0.12 of that module, which should already contain that fix, right?

@code-asher
Copy link
Member

Are you able to download and extract https://github.com/coder/code-server/releases/download/v4.23.1/code-server-4.23.1-linux-amd64.tar.gz on that remote machine? And does it happen consistently? I wonder if it was some network blip that corrupted the file.

@code-asher
Copy link
Member

Since it is installing from cache you might have to delete ~/.cache/code-server/code-server-4.23.1-linux-amd64.tar.gz before trying again. Possibly we need to add a checksum to the install script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer
Projects
None yet
Development

No branches or pull requests

3 participants