Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev]: add e2e test for dev workflow (yarn watch) #2963

Closed
jsjoeio opened this issue Mar 25, 2021 · 1 comment
Closed

[dev]: add e2e test for dev workflow (yarn watch) #2963

jsjoeio opened this issue Mar 25, 2021 · 1 comment
Assignees
Labels
ci Issues related to ci enhancement Some improvement that isn't a feature stale This issue has not had activity in a while and will be closed testing Anything related to testing
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 25, 2021

After hours of debugging and a false positive with a dependabot PR, we've come to the conclusion that we should have testing in place for our dev workflow: yarn watch.

This will prevent issues like #2962 from happening again.

One way to achieve this is by:

  • adding a new script called yarn test:watch which is similar to yarn test:e2e
  • add new CI step/job for running the e2e tests against code-server running with yarn watch

We'd have to add some timeout or sleep though since running with yarn watch takes time to finish.

Related:

@jsjoeio jsjoeio added this to the On Deck milestone Mar 25, 2021
@jsjoeio jsjoeio added this to ⌛ To do in Improve Testing via automation Mar 25, 2021
@jsjoeio jsjoeio added ci Issues related to ci enhancement Some improvement that isn't a feature labels Mar 25, 2021
@jsjoeio jsjoeio modified the milestones: On Deck, v3.9.5 May 3, 2021
@jsjoeio jsjoeio self-assigned this May 7, 2021
@jsjoeio jsjoeio added the testing Anything related to testing label May 14, 2021
@code-asher code-asher modified the milestones: v3.10.1, 3.11.0 May 17, 2021
@jsjoeio jsjoeio modified the milestones: 3.10.2, 3.11.0 May 21, 2021
@jsjoeio jsjoeio modified the milestones: 3.11.0, 3.12.0 Jul 19, 2021
@jsjoeio jsjoeio modified the milestones: 3.12.0, On Deck Aug 11, 2021
@stale
Copy link

stale bot commented Feb 7, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale This issue has not had activity in a while and will be closed label Feb 7, 2022
@stale stale bot closed this as completed Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues related to ci enhancement Some improvement that isn't a feature stale This issue has not had activity in a while and will be closed testing Anything related to testing
Projects
None yet
Development

No branches or pull requests

2 participants