Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences between v1 and v2 re: commanline arguments #1019

Closed
aptalca opened this issue Sep 22, 2019 · 7 comments
Closed

Differences between v1 and v2 re: commanline arguments #1019

aptalca opened this issue Sep 22, 2019 · 7 comments

Comments

@aptalca
Copy link

aptalca commented Sep 22, 2019

Hi,

Looking at the output of code-server --help, I see there are a lot of differences between v1 and v2. Is there any documentation that details the changes for users upgrading from v1 to v2?

More specifically. . .

  1. Is -d still supported or only --user-data-dir?
  2. Is -e still supported or only --extensions-dir?
  3. Is --disable-telemetry still supported?
  4. Is -N supported or is it automatic based on whether the PASSWORD env var is set?
  5. Is -H supported or is it automatic based on whether a cert is selected?

Also I see that the documentation was updated to reference port 8080 instead of 8443 everywhere, but the latest stable release still uses 8443, just fyi

Thanks

@sr229
Copy link
Contributor

sr229 commented Sep 22, 2019

Please refer to the --help output.

TLDR: we only pass VSCode commands going forward with our additions. See GH-857.

@sr229
Copy link
Contributor

sr229 commented Sep 22, 2019

As for the port change, it was requested for our venerable Google Cloud Run users.

@aptalca
Copy link
Author

aptalca commented Sep 23, 2019

I guess I didn't make myself clear. My questions above were a result of comparing the --help output in the two versions.

I'll go ahead and assume the --help output of v2 is 100% accurate and that all those options from v1 have been dropped.

Then how do I make sure telemetry is disabled? I don't see a telemetry entry in the code-server gui settings as described in vscode docs: https://code.visualstudio.com/docs/getstarted/telemetry#_disable-telemetry-reporting

Thanks

@sr229
Copy link
Contributor

sr229 commented Sep 23, 2019

@aptalca you can use the --disable-telemetry option. VSCode web by default sends telemetry and there is no GUI to support such on upstream.

@aptalca
Copy link
Author

aptalca commented Sep 23, 2019

Thanks.

Then perhaps that option should be added to the --help output?

@antofthy
Copy link

antofthy commented Oct 4, 2019

--disable-telemetry is not listed in the --help for v2.
Instead --telemetry is listed however any attempt my me to use it results in "error File not found"

Using -auth password will accept the password to use from the $PASSWORD environment variable just as it is for v1.

@code-asher
Copy link
Member

code-asher commented Oct 7, 2019

We just display what VS Code displays and it seems they opt not to show --disable-telemetry but it's still a valid flag (as it is with desktop VS Code). https://github.com/cdr/code-server#telemetry. The options that do appear are accurate and the ones that no longer appear are gone with the exception of --disable-telemetry.

I'm not sure what --telemetry is supposed to do but when I run it it seems to require a telemetry-core.json file and fails when it can't find it (the same thing happens to me with "normal" VS Code).

I'm not sure why the disable telemetry option doesn't show in the settings but it's on my list to look into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants