Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support combine.keys #76

Merged
merged 1 commit into from Dec 7, 2019
Merged

Support combine.keys #76

merged 1 commit into from Dec 7, 2019

Conversation

rfscholte
Copy link
Member

No description provided.

@rfscholte rfscholte merged commit 844da90 into master Dec 7, 2019
public void testCombineKeys()
throws Exception
{
String lhs = "<props>" + "<property combine.keys='name'><name>LHS-ONLY</name><value>LHS</value></property>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ok? according to the readme in https://github.com/atteo/xml-combiner, the value of combine.keys are attributes names, and here are tag names.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I see what you mean. In case of Maven I am missing the ability to identity the key of complex objects.
But there's indeed something else wrong: combine.keys shõuld not be on the element itself, but the wrapping element. And with that I understand why it is for attributes. I need to have another look at it.

Great catch!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hboutemy hboutemy deleted the combine.keys branch February 7, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants