Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve speed for Xpp3Dom clone / merge operations #67

Closed
wants to merge 4 commits into from
Closed

Improve speed for Xpp3Dom clone / merge operations #67

wants to merge 4 commits into from

Conversation

gnodet
Copy link
Member

@gnodet gnodet commented Jul 3, 2019 •
edited 

Before:
Benchmark                        Mode  Cnt     Score     Error   Units
Xpp3DomPerfTest.benchmarkClone  thrpt    3  4367,683 ± 361,351  ops/ms
Xpp3DomPerfTest.benchmarkMerge  thrpt    3  3891,716 ± 289,711  ops/ms

After:
Benchmark                        Mode  Cnt     Score     Error   Units
Xpp3DomPerfTest.benchmarkClone  thrpt    3  7062,259 ± 713,564  ops/ms
Xpp3DomPerfTest.benchmarkMerge  thrpt    3  4941,132 ± 446,558  ops/ms

michael-o
michael-o reviewed Jul 3, 2019
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question open

@gnodet gnodet mentioned this pull request Jul 3, 2019
Merged
michael-o
michael-o approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Will run tests and merge at noon.

@michael-o michael-o closed this in 6dfc0a6 Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gnodet @michael-o