Fix #7: Enforce check against Java 6 API signature. #8
+34
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
belingueres
commented
May 18, 2019
belingueres
commented
- Added enforcer rule.
- Added myself as dev.
hboutemy
reviewed
Dec 3, 2019
pom.xml
Outdated
| <checkSignatureRule implementation="org.codehaus.mojo.animal_sniffer.enforcer.CheckSignatureRule"> | ||
| <signature> | ||
| <groupId>org.codehaus.mojo.signature</groupId> | ||
| <artifactId>java16</artifactId> |
There was a problem hiding this comment.
using ${javaVersion} instead of 6 would be more flexible for child projects
There was a problem hiding this comment.
Changed. However to be useful in child projects, should I change version to 1.0? (version 1.1 of the signatures are only available for java16.)
There was a problem hiding this comment.
yes, please: I don't know how Java 1.6 signatures 1.0 were broken, but let's hope they work sufficiently
and I suppose we'll upgrade minimum Java version soon, so that will be a question of past :)
|
do we really still need this :) maybe java 7 at lease.. |
|
+1 if there is consensus to raise to java 7. |
|
that's one advantage of using a property: the discussion can happen later, tracked with another issue |
- Added enforcer rule. - Added myself as dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.