Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Java version to 1.8 #28

Merged
merged 1 commit into from Dec 21, 2020
Merged

Bump Java version to 1.8 #28

merged 1 commit into from Dec 21, 2020

Conversation

mkarg
Copy link
Contributor

@mkarg mkarg commented Dec 21, 2020

Java SE 8 is supported since 2014, and should be available on most platforms meanwhile. It provides new APIs which are benficial to Plexus, e. g. improved IO handling, etc. I'd like to start a discussion, when to align Plexus with Maven and make Java 8 the minimum supported version.

Signed-off-by: Markus KARG <markus@headcrashing.eu>
@michael-o
Copy link
Member

I wonder whether we could switch to integer versions of this POM w/ minor releases which do not really make sense with parents. I'd happy if we could move to Parent version 7.

@mkarg
Copy link
Contributor Author

mkarg commented Dec 21, 2020

I wonder whether we could switch to integer versions of this POM w/ minor releases which do not really make sense with parents. I'd happy if we could move to Parent version 7.

Just to understand you correctly: You want to replace "1.7" by "7", but not by "8"?

@michael-o
Copy link
Member

I wonder whether we could switch to integer versions of this POM w/ minor releases which do not really make sense with parents. I'd happy if we could move to Parent version 7.

Just to understand you correctly: You want to replace "1.7" by "7", but not by "8"?

No, no. I was completely referring to

<version>6.6-SNAPSHOT</version>
.

@mkarg
Copy link
Contributor Author

mkarg commented Dec 21, 2020

No, no. I was completely referring to

<version>6.6-SNAPSHOT</version>

Understood, but what is the process to do that? Can we simply do that in this PR (in the sense of "we need to step up because of Java 8"), or shouldn't we open another PR first just for that (in the sense of "it is time to step up now anyways, so in turn we could then do Java 8")? See, these are different discussions...

@michael-o
Copy link
Member

I would prefer to have a new version of the parent POM with a separate PR and then this one.

@michael-o
Copy link
Member

I'd also release of currently open components a last Java 7 version before moving to the new parent POM version.

@mkarg
Copy link
Contributor Author

mkarg commented Dec 21, 2020

I would prefer to have a new version of the parent POM with a separate PR and then this one.

Understood. So here we go: #29 :-)

@mkarg
Copy link
Contributor Author

mkarg commented Dec 21, 2020

I'd also release of currently open components a last Java 7 version before moving to the new parent POM version.

Ok, need to let you do that -- I cannot perform releases AFAIK (or have not found out how to).

@michael-o michael-o merged commit 8030bd5 into codehaus-plexus:master Dec 21, 2020
@mkarg mkarg deleted the Java-8 branch December 22, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants