This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Reproducible metadata #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update the PR? |
|
What update would you like? The PR has no conflict with the current code, but Travis is reporting a failure that seems unrelated (the build worked at least with Java 8). |
|
travis file has been changed on master. that should make this branch succeed as well |
|
I rebased the PR on top of the plexus-containers-1.x branch |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The components.xml file generated by the plexus-containers-metadata plugin isn't deterministic. The output varies depending on the computer/JDK/architecture used. In order to make the output reproducible I suggest sorting the components descriptors before writing them. Here is an implementation with its unit test.
This patch has been tested in Debian as part of the reproducible builds effort.
Thank you