Upgrade the minimum required Java version to 7 and Plexus IO to 3.0.0 #56
Conversation
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
This method is obsolete but since it's public I think it's better to keep it for now (maybe until the next major release?).
|
I suppose I should update |
|
That would be nice. |
| @@ -114,11 +110,6 @@ | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
| <configuration> | |||
| <systemPropertyVariables> | |||
| <useJvmChmod>${useJvmChmod}</useJvmChmod> | |||
There was a problem hiding this comment.
What about Surefire? That code did not change.
There was a problem hiding this comment.
The useJvmChmod system property is no longer used, so there is no point
in setting it. That is why I've removed it from the Surefire configuration.
| @@ -351,7 +351,7 @@ else if ( isDirectory ) | |||
|
|
|||
| if ( !isIgnorePermissions() && mode != null && !isDirectory ) | |||
| { | |||
| ArchiveEntryUtils.chmod( f, mode, getLogger(), isUseJvmChmod() ); | |||
There was a problem hiding this comment.
Logger is not necessary anymore?
There was a problem hiding this comment.
Yes, it was used to log the output of the 'chmod' command, so it is no
longer needed.
|
@michael-o excuse me for the comments, those were meant to be replies to your inline comments. Looks like the reply by mail feature does not work as good as I expected. I've added them as inline comments. |
|
No big deal. |
It may seem that there are lot of changes but actually most of them are: * Rename `Java7FileAttributes` to `FileAttributes`. In the new version of Plexus IO `FileAttributes` is replaced by `Java7FileAttributes` * Remove calls to `Java7Reflector.isAtLeastJava7()`. `Java7Reflector` is deleted from the new version of Plexus IO because now at least Java 7 is required The most significant change is made inside `ArchiveEntryUtils#chmod` - now the Java version is at least 7 so together with the removal of the call to `Java7Reflector.isAtLeastJava7()` the legacy code is removed as well. Remove the `commons-io` dependency. Plexus IO 3.0.0 was updated to use `commons-io` 2.5 so there is no longer a need to override the transitive dependency.
Prior to Java 7, the `chmod` command was used to change the files mode. `useJvmChmod` was a way to force the usage of the JVM instead of the external command. Now Java 7 is the minimum required version and no external commands are needed to change the files mode and useJvmChmod` is just ignored. Deprecate this setting so it can be removed from future versions.
|
I've updated the PR with the Plexus 3.0.0 release version instead of SNAPSHOT. Also I've removed the commons-io dependency. In Plexus 3.0.0 it is updated to 2.5 already so there is no need to override it. |
|
Merged, thank you. |
This pull request updates the minimum required Java version to 7 and the Plexus IO version to 3.0.0
After the update to Java 7
useJvmChmodis just ignored. I've added deprecation annotation so it can be removed in future.