-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks are failing even thought they are informational #386
Comments
Hi @nwalters512 , You are missing the check's name.
Should be
|
@rohan-at-sentry I called this out here https://docs.codecov.com/docs/codecovyml-reference#coveragestatus, but it appears to have never made it to (or was lost from) the main docs. |
Thanks for pointing that out; sorry I missed that in the docs! For what it's worth, I ran my config through the validator as recommended in your docs and it said it was valid:
It would be very helpful if the validator complained about my config. On a closer look, I see that the docs at https://docs.codecov.com/docs/commit-status#disabling-a-status state the following:
It seems as though neither the validator nor the implementation agree with this. |
:-/ 👀 |
It's because in order to handle "False" it's of type "boolean" So it's "valid", just...doesn't do anything 🤐 @rohan-at-sentry I feel there's room for improvement here, but I don't know the safest way to modify something so core to Codecov operations. I added the note, but It's a valid point that if it validates.... |
Describe the bug
I've configured the project and patch status checks to be informational:
The documentation on https://docs.codecov.com/docs/commit-status states that the status checks should never fail when marked as informational:
However, they're both failing on this PR: PrairieLearn/PrairieLearn#9743
Environment:
To Reproduce
I'm not entirely sure what to put here; I think I've given as much information as I can. A repo containing the above YAML configuration does not behave as the documentation says it should. This is visible on PrairieLearn/PrairieLearn#9743.
Expected behavior
Per the documentation, informational checks should never fail.
Screenshots
The text was updated successfully, but these errors were encountered: