Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage status not being set #374

Open
ljharb opened this issue May 13, 2024 · 12 comments
Open

coverage status not being set #374

ljharb opened this issue May 13, 2024 · 12 comments
Labels
Support For general support questions, e.g. onboarding or configuration Waiting for: Product Owner

Comments

@ljharb
Copy link

ljharb commented May 13, 2024

Describe the bug
For example, es-shims/iterator-helpers#6. The two codecov statuses sit on "pending" forever.

Expected behavior
a PR status is set.

@ljharb
Copy link
Author

ljharb commented May 14, 2024

shamelessly ccing @chadwhitacre for visibility; it seems like a big deal if all 500 of my projects' codecov integrations have stopped working, and i'd love to help yall fix it :-)

@drazisil-codecov
Copy link

Hi @ljharb ,

I took a look. Can you please share where you are uploading coverage files to Codecov? I don't see it here in the repo https://github.com/search?q=repo%3Aes-shims%2Fiterator-helpers%20codecov&type=code

@ljharb
Copy link
Author

ljharb commented May 14, 2024

@drazisil-codecov it's through a composite action, the line ends up being from here: https://github.com/ljharb/actions/blob/main/.github/workflows/node.yml#L167-L168

@drazisil-codecov
Copy link

Hi @ljharb ,

Can you show me where in the CI run the upload occurred? I need to see the output.

@thomasrockhu-codecov thomasrockhu-codecov added the Support For general support questions, e.g. onboarding or configuration label May 14, 2024
@ljharb
Copy link
Author

ljharb commented May 14, 2024

@drazisil-codecov sure! in theory it uploaded 25 different jobs (the number of "latest" node minor versions being tested; i don't submit coverage on non-latest ones, because of rate limits).

https://github.com/es-shims/iterator-helpers/actions/runs/9057764832/job/24882348643#step:12:33 is one example, in which it says it's a 429 - https://github.com/es-shims/iterator-helpers/actions/runs/9057764835/job/24882277307 is another.

How low are the rate limits that it can't even get one job out of a mere 25?

@ljharb
Copy link
Author

ljharb commented May 31, 2024

@drazisil-codecov @thomasrockhu-codecov any update here? codecov is still not working on any of my projects.

@drazisil-codecov
Copy link

Hi @ljharb ,

Sorry, I took a mini vacation and this was lost.

[2024-05-13T05:37:58.242Z] ['info'] -> No token specified or token is empty
Please upload with the Codecov repository upload token to resolve issue.

Due to rate limit issues (aka, use Codecov's GitHub API rate limit for everything public) we require you to use your upload token when calling Codecov. Tokenless is still supported on forks to prevent your token leaking via CI.

@thomasrockhu-codecov
Copy link
Contributor

@ljharb just fyi, you might find this issue and this issue of interest

@ljharb
Copy link
Author

ljharb commented May 31, 2024

@drazisil-codecov that's simply not a viable path. I have 500+ repos across multiple users and orgs, and some of them I have no capability of adding secrets (user-owned repos that aren't owned by me).

@thomasrockhu-codecov thanks! subscribed.

If tokenless usage isn't viable moving forwards, then codecov's usefulness to open source for me is basically gone, which is sad because it's the best product. @chadwhitacre is there potentially another long term plan here that doesn't require admin access on repos?

@drazisil-codecov
Copy link

@rohan-at-sentry ^

@rohan-at-sentry
Copy link

@ljharb - Do you know if the repos that are experiencing this issue are set up with the Codecov Github bot?

@ljharb
Copy link
Author

ljharb commented Jun 3, 2024

@rohan-at-sentry All of the ones that i have admin rights on should be using the GitHub app - i can’t check or control the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support For general support questions, e.g. onboarding or configuration Waiting for: Product Owner
Projects
Status: Waiting for: Product Owner
Development

No branches or pull requests

4 participants