Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository not found isn't helpful #366

Open
jsoref opened this issue May 8, 2024 · 10 comments
Open

Repository not found isn't helpful #366

jsoref opened this issue May 8, 2024 · 10 comments

Comments

@jsoref
Copy link

jsoref commented May 8, 2024

Describe the bug

Some "http server" is yielding HTTP Error 400 with a message of Repository not found. This isn't actionable. Nor is there any content on https://docs.codecov.com/docs/ for this message

debug - 2024-05-07 14:00:41,055 -- Starting create commit process --- {"commit_sha": "a07975eaa2b0aeb8af59538d8f62e91c35d72739", "parent_sha": null, "pr": null, "branch": "my-repo-is-not-a-fork", "slug": "check-spelling-sandbox/eslint-plugin-jest", "token": "e******************", "service": "github", "enterprise_url": null}
info - 2024-05-07 14:00:41,270 -- Process Commit creating complete
debug - 2024-05-07 14:00:41,271 -- Commit creating result --- {"result": "RequestResult(error=RequestError(code='HTTP Error 400', params={}, description='[\"Repository not found\"]'), warnings=[], status_code=400, text='[\"Repository not found\"]')"}
error - 2024-05-07 14:00:41,271 -- Commit creating failed: ["Repository not found"]

Environment (please complete the following information):

To Reproduce
Steps to reproduce the behavior:

  1. Create fork https://github.com/check-spelling-sandbox/eslint-plugin-jest/
  2. Add commits to https://github.com/check-spelling-sandbox/eslint-plugin-jest/tree/my-repo-is-not-a-fork up to check-spelling-sandbox/eslint-plugin-jest@a07975e
  3. Wait for the workflow to fail
  4. Visit a failed job, e.g. https://github.com/check-spelling-sandbox/eslint-plugin-jest/actions/runs/8986717338/job/24683540548
  5. See error

Expected behavior
Clear error messages explaining what was done, what was seen, and why that results in a specific error.

Screenshots

log
2024-05-07T14:00:39.6055923Z ##[group]Run check-spelling-sandbox/codecov-action@my-repo-is-not-a-fork
2024-05-07T14:00:39.6056646Z with:
2024-05-07T14:00:39.6056984Z   fail_ci_if_error: true
2024-05-07T14:00:39.6057555Z   use_oidc: true
2024-05-07T14:00:39.6057915Z   verbose: true
2024-05-07T14:00:39.6058259Z ##[endgroup]
2024-05-07T14:00:39.7598791Z ==> Got an OIDC token
2024-05-07T14:00:39.7730797Z ==> Got an OIDC token
2024-05-07T14:00:39.7987949Z ==> Got an OIDC token
2024-05-07T14:00:39.7990671Z ==> linux OS detected
2024-05-07T14:00:40.1397725Z https://cli.codecov.io/latest/linux/codecov.SHA256SUM
2024-05-07T14:00:40.2276064Z Received SHA256SUM e70beb7c9e3d894678e7d4d0fcb94e59133212dbda5ca7406b625a0167ce4ca8  codecov
2024-05-07T14:00:40.3069008Z Received SHA256SUM signature -----BEGIN PGP SIGNATURE-----
2024-05-07T14:00:40.3069621Z 
2024-05-07T14:00:40.3070178Z iQIzBAABCgAdFiEEJwNOf9uFDgu8LGL/gGuyiu13mGkFAmYhSq4ACgkQgGuyiu13
2024-05-07T14:00:40.3071073Z mGkULA/8Dq6mYMCj4DxoHtfQeiQ3FZ/8HrgQmwUICQa5QHatbojQLmsYkruvvWWl
2024-05-07T14:00:40.3071851Z +Q7PywoiEWkFQ6nI1Wb4sTLWAMwdjjCKSECqTs9jlqXklKDKyb1Fv5O0ytwFEe/a
2024-05-07T14:00:40.3072598Z Wc4V4CKvH3LFHWB/ZsFMmjBBLQ3evQqz5rfk+Bih5uV/RtcNoLnWstaIqyeISyb4
2024-05-07T14:00:40.3073364Z NdgLWy9uapyeHfoPoZ6HEdrNhy4LvMrlCbgjwjFLZ445fE0Neq4n3QOlDKZ+RviO
2024-05-07T14:00:40.3074124Z FU/zYlZkWyHxrDavBEotbSWRCNB/ptyTc9uuQXEtemrJKoJYNRAIBx7N60uEEpCO
2024-05-07T14:00:40.3074889Z oDzALNV404Tw7WiULHyUhuxeN4EDiu2mCoa1KiMjFHjOayY6lREtsvt94ubGmAJ1
2024-05-07T14:00:40.3075656Z y29LiEvYIxEzd7nJcC8PzxbZk6AUv3IXA8o9m47KCVqKFMCFCTgc8fEWlrIfRtLN
2024-05-07T14:00:40.3076423Z HupcoOOuV7SWHXfg5vOf0vclnTpw3MVcrj+Z7dMA5OSpqcTlL8ACb9QPsKpAesUR
2024-05-07T14:00:40.3077235Z tth7zorPoU/RHfgEgKNPmKX9vvqB+AZ2n2oCPhlYOBP6/9NFjoIvIfWZPD9FSce7
2024-05-07T14:00:40.3077952Z K4FOEyaBEyypUMXtjPVj8MtoOaLk/X9g03ZKAlDxbnBIqqp0YLbqMW+nZkG8TTKI
2024-05-07T14:00:40.3078578Z e4d6XX447TyQ2750658NX+9Z/0c/oK+jsNCG2uocOkIL3kOHtAw=
2024-05-07T14:00:40.3078999Z =QUC9
2024-05-07T14:00:40.3079320Z -----END PGP SIGNATURE-----
2024-05-07T14:00:40.3079530Z 
2024-05-07T14:00:40.3128345Z ==> Running version latest
2024-05-07T14:00:40.3410620Z gpg: directory '/home/runner/.gnupg' created
2024-05-07T14:00:40.3411621Z gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
2024-05-07T14:00:40.3412554Z gpg: /home/runner/.gnupg/trustdb.gpg: trustdb created
2024-05-07T14:00:40.3413993Z gpg: key 806BB28AED779869: public key "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" imported
2024-05-07T14:00:40.3414780Z gpg: Total number processed: 1
2024-05-07T14:00:40.3415146Z gpg:               imported: 1
2024-05-07T14:00:40.3415362Z 
2024-05-07T14:00:40.3473421Z gpg: Signature made Thu Apr 18 16:30:38 2024 UTC
2024-05-07T14:00:40.3474464Z gpg:                using RSA key 27034E7FDB850E0BBC2C62FF806BB28AED779869
2024-05-07T14:00:40.3476090Z gpg: Good signature from "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" [unknown]
2024-05-07T14:00:40.3477619Z gpg: WARNING: This key is not certified with a trusted signature!
2024-05-07T14:00:40.3478865Z gpg:          There is no indication that the signature belongs to the owner.
2024-05-07T14:00:40.3480150Z Primary key fingerprint: 2703 4E7F DB85 0E0B BC2C  62FF 806B B28A ED77 9869
2024-05-07T14:00:40.3480853Z 
2024-05-07T14:00:40.3699709Z ==> Running version v0.5.2
2024-05-07T14:00:40.3703469Z ==> Running git config --global --add safe.directory /home/runner/work/eslint-plugin-jest/eslint-plugin-jest
2024-05-07T14:00:40.3748982Z [command]/usr/bin/git config --global --add safe.directory /home/runner/work/eslint-plugin-jest/eslint-plugin-jest
2024-05-07T14:00:40.3803541Z ==> Running command '/home/runner/work/_actions/check-spelling-sandbox/codecov-action/my-repo-is-not-a-fork/dist/codecov -v create-commit'
2024-05-07T14:00:40.3806100Z [command]/home/runner/work/_actions/check-spelling-sandbox/codecov-action/my-repo-is-not-a-fork/dist/codecov -v create-commit --git-service github -Z
2024-05-07T14:00:40.4164004Z ==> Uploader SHASUM verified (e70beb7c9e3d894678e7d4d0fcb94e59133212dbda5ca7406b625a0167ce4ca8  codecov)
2024-05-07T14:00:41.0462995Z info - 2024-05-07 14:00:41,045 -- ci service found: github-actions
2024-05-07T14:00:41.0490081Z debug - 2024-05-07 14:00:41,048 -- versioning system found: <class 'codecov_cli.helpers.versioning_systems.GitVersioningSystem'>
2024-05-07T14:00:41.0516911Z debug - 2024-05-07 14:00:41,051 -- versioning system found: <class 'codecov_cli.helpers.versioning_systems.GitVersioningSystem'>
2024-05-07T14:00:41.0544043Z debug - 2024-05-07 14:00:41,054 -- Loading config from /home/runner/work/eslint-plugin-jest/eslint-plugin-jest/.codecov.yml
2024-05-07T14:00:41.0560566Z debug - 2024-05-07 14:00:41,055 -- Starting create commit process --- {"commit_sha": "a07975eaa2b0aeb8af59538d8f62e91c35d72739", "parent_sha": null, "pr": null, "branch": "my-repo-is-not-a-fork", "slug": "check-spelling-sandbox/eslint-plugin-jest", "token": "e******************", "service": "github", "enterprise_url": null}
2024-05-07T14:00:41.2716073Z info - 2024-05-07 14:00:41,270 -- Process Commit creating complete
2024-05-07T14:00:41.2719015Z debug - 2024-05-07 14:00:41,271 -- Commit creating result --- {"result": "RequestResult(error=RequestError(code='HTTP Error 400', params={}, description='[\"Repository not found\"]'), warnings=[], status_code=400, text='[\"Repository not found\"]')"}
2024-05-07T14:00:41.2721514Z error - 2024-05-07 14:00:41,271 -- Commit creating failed: ["Repository not found"]
2024-05-07T14:00:41.3383207Z ##[error]Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/check-spelling-sandbox/codecov-action/my-repo-is-not-a-fork/dist/codecov' failed with exit code 1

Additional context

  • I'm trying to get OIDC working.
  • I've added additional logging to a fork of codecov/codecov-action to confirm that I'm using OIDC.
@jsoref
Copy link
Author

jsoref commented May 8, 2024

Personally, I'm half guessing codecov made a call to https://api.github.com/ -- I'd really like to know what api call it made (and at least what identity it used -- I obviously don't want the credentials...)

As an end user, from my perspective, the repository is public

So, Repository not found is misleading/confusing -- what wasn't found?

@drazisil-codecov
Copy link

Hi @jsoref ,

We just merged a fix for the OIDC, can you please try again?

@jsoref
Copy link
Author

jsoref commented May 9, 2024

@drazisil-codecov: to which repository? (Do I need to update my fork of the codecov-action repository?)

@drazisil-codecov
Copy link

Hi @jsoref

I believe it was to API so no updates should be needed on your side. I'm confirming with the engineer.

@jsoref
Copy link
Author

jsoref commented May 9, 2024

@drazisil-codecov here's a new (failed) run from the same commit: https://github.com/check-spelling-sandbox/eslint-plugin-jest/actions/runs/8986717338/job/24776595047

@drazisil-codecov
Copy link

I have passed the details back to the engineer.

@thomasrockhu-codecov
Copy link
Contributor

@jsoref it's me again, I think I have found the root cause here, thanks for being patient. We'll work on a fix.

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this May 9, 2024
@jsoref
Copy link
Author

jsoref commented May 9, 2024

@thomasrockhu-codecov: I appreciate fixing the underlying error, but it'd really be nice if the error message itself were improved.

Anyway, @ me when you want me to try again. I'm usually fairly responsive 🙂 .

@thomasrockhu-codecov
Copy link
Contributor

@jsoref yeah, I guess the problem is more that you should not have seen that error message to begin with. Definitely a bug on our side

@jsoref
Copy link
Author

jsoref commented May 16, 2024

Fwiw, here's a round where the codecov-action is now configured to self-test using oidc: https://github.com/check-spelling-sandbox/codecov-action/actions/runs/9116103249/job/25063948144

on the bright side, it fails pretty fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for: Product Owner
Development

No branches or pull requests

3 participants