Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Enable branch coverage #73

Open
klyonrad opened this issue Jul 14, 2020 · 7 comments
Open

Enable branch coverage #73

klyonrad opened this issue Jul 14, 2020 · 7 comments

Comments

@klyonrad
Copy link

klyonrad commented Jul 14, 2020

The simplecov gem added support for displaying branch coverage for a while now.
It would be nice if codecov would do that too.

@thomasrockhu
Copy link
Contributor

Thanks here @klyonrad, we are looking to support Simplecov 0.18+ and will add its branch coverage to the product map.

@thomasrockhu thomasrockhu self-assigned this Nov 5, 2020
@thomasrockhu
Copy link
Contributor

@klyonrad, do you have a build with branch coverage? Now that 0.18+ is supported, we'd love to move forward here.

@klyonrad
Copy link
Author

klyonrad commented Nov 5, 2020

Sorry, @thomasrockhu I don't quite understand the question or what you require. I used branch coverage a couple of times in my projects and it worked. Enabling it should require minimal configuration

@thomasrockhu
Copy link
Contributor

@klyonrad, sorry for not explaining myself more. Do you have a public repository that is currently collecting branch coverage?

@klyonrad
Copy link
Author

klyonrad commented Dec 9, 2020

@marcotc
Copy link

marcotc commented Feb 2, 2021

👋 @thomasrockhu, our team was also trying to report branch coverage results and noticed that they don't get picked up by the codecov gem. We submit our results by configuring the SimpleCov::Formatter::Codecov: https://github.com/DataDog/dd-trace-rb/blob/7e6fdb0a8c948a9e36f6f618350566e74c2d92b1/Rakefile#L958-L967

Like @thomasrockhu said, adding SimpleCov.enable_coverage :branch to any project that is currently exporting to Codecov will allow you to see that "branches": [...] data is present in the .resultset.json SimpleCov result, but not present in the payload sent by codecov.

@thomasrockhu
Copy link
Contributor

Hi @marcotc! We are working on parsing the branch coverage information this month. After that's in place, I'll be making the change to the uploader to send that information to Codecov using this gem. I'll ping back here with updates, but we are really looking forward to getting this feature rolled out.

@thomasrockhu thomasrockhu removed their assignment Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants