Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Added option to disable printing of gcov-out #305

Merged
merged 1 commit into from Dec 10, 2020
Merged

Added option to disable printing of gcov-out #305

merged 1 commit into from Dec 10, 2020

Conversation

nmoinvaz
Copy link
Contributor

@nmoinvaz nmoinvaz commented Dec 2, 2020

This is similar to the same option by the same name in the bash uploader. Any errors written out to stderr by gcov will still be output in the Popen call. This PR should also help with #168.

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #305 (b40cb0a) into master (5862842) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #305   +/-   ##
=====================================
  Coverage      88%    88%           
=====================================
  Files           2      2           
  Lines           9      9           
=====================================
  Hits            8      8           
  Misses          1      1           

@nmoinvaz
Copy link
Contributor Author

nmoinvaz commented Dec 2, 2020

@thomasrockhu it would be great to get this feature into a release. At work we have a large project with many sources files and the build logs get full easily with the gcov output. Thanks in advance!

Comment on lines 988 to 989
if codecov.gcov_out:
write(" Executing gcov (%s)" % cmd)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should write this regardless

Suggested change
if codecov.gcov_out:
write(" Executing gcov (%s)" % cmd)
write(" Executing gcov (%s)" % cmd)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few lines above, it says Processing gcov.. One of the reasons I thought it might not be necessary is that each of the gcov files is listed under Collecting reports.

image

Let me know if you would still like it printed.

codecov/__init__.py Outdated Show resolved Hide resolved
codecov/__init__.py Outdated Show resolved Hide resolved
@nmoinvaz
Copy link
Contributor Author

nmoinvaz commented Dec 8, 2020

@thomasrockhu I have made some of the requested changes.

@thomasrockhu thomasrockhu merged commit 58032a4 into codecov:master Dec 10, 2020
@nmoinvaz
Copy link
Contributor Author

Thanks!

@nmoinvaz
Copy link
Contributor Author

With this PR our coverage build logs went from 426KB to 114KB.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants