Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

CircleCI: inconsistent args for build/job with codecov-python #221

Open
blueyed opened this issue Oct 29, 2017 · 2 comments
Open

CircleCI: inconsistent args for build/job with codecov-python #221

blueyed opened this issue Oct 29, 2017 · 2 comments

Comments

@blueyed
Copy link
Contributor

blueyed commented Oct 29, 2017

https://github.com/codecov/codecov-bash/blob/7e6cfa3935aeb29de57298bda496dad27b24aa37/codecov#L541-L542

vs

build=os.getenv('CIRCLE_BUILD_NUM') + "." + os.getenv('CIRCLE_NODE_INDEX'),
job=os.getenv('CIRCLE_BUILD_NUM') + "." + os.getenv('CIRCLE_NODE_INDEX'),

build=os.getenv('CIRCLE_BUILD_NUM') + "." + os.getenv('CIRCLE_NODE_INDEX'),
job=os.getenv('CIRCLE_BUILD_NUM') + "." + os.getenv('CIRCLE_NODE_INDEX'),
@drazisil
Copy link
Contributor

This may be a bug in the python uploader, or it is handled differently. The bash uploader correctly handles CircleCI build URLs.

@blueyed
Copy link
Contributor Author

blueyed commented Nov 20, 2019

@drazisil
Ok. Can you move the issue there then?
(This issue just documents / points out that they differ - I cannot say which is correct, but they should be the same)

@drazisil drazisil transferred this issue from codecov/codecov-bash Nov 22, 2019
@drazisil drazisil reopened this Nov 22, 2019
@thomasrockhu thomasrockhu self-assigned this Nov 29, 2020
@thomasrockhu thomasrockhu removed their assignment Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants