Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Run Python 'coverage' tool as a module if possible #202

Merged
merged 2 commits into from Jun 7, 2019

Conversation

takluyver
Copy link
Contributor

This means coverage can still be called to convert its data to XML even if it's not on PATH.

Closes #71.

This means coverage can still be called to convert its data to XML even if it's not on PATH.

Closes codecov#71.
@takluyver takluyver mentioned this pull request Jun 3, 2019
@takluyver
Copy link
Contributor Author

Something's going wrong on Travis and the Python interpreter is going to interactive mode. I'm guessing it's picking up the -i flag meant for coverage. Trying to see if I can replicate this locally.

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #202 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #202   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           1      1           
  Lines           1      1           
=====================================
  Misses          1      1

@takluyver
Copy link
Contributor Author

OK, resolved the problem in Travis by using shell=False for those calls. This means that the Python (coverage) process is a direct subprocess, rather than having an intermediate shell process.

@thomasrockhu thomasrockhu merged commit de92d4f into codecov:master Jun 7, 2019
@takluyver takluyver deleted the patch-2 branch June 7, 2019 17:54
@takluyver
Copy link
Contributor Author

Thanks! When you've got time, it would be great to see a new release on PyPI. :-)

@takluyver
Copy link
Contributor Author

Ping @stevepeak - any chance of a new release of codecov-python? Maybe @thomasrockhu needs to be added on PyPI so he can make a release?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to exec coverage
3 participants