Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Better error message when try_to_run command fails #201

Merged
merged 1 commit into from Jun 7, 2019

Conversation

takluyver
Copy link
Contributor

The CalledProcessError object should always have a .output attribute, although it may be None, so the getattr() will never hit the fallback condition.

The logical or operator should use the fallback if e.output is either None or an empty string, because those are both false-y. Any other possible value will be shown.

The `CalledProcessError` object should always have a `.output` attribute, although it may be None, so the `getattr()` will never hit the fallback condition.

The logical `or` operator should use the fallback if `e.output` is either None or an empty string, because those are both false-y. Any other possible value will be shown.
@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #201   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           1      1           
  Lines           1      1           
=====================================
  Misses          1      1

@thomasrockhu thomasrockhu merged commit 3502fdd into codecov:master Jun 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants