From eac0a1e46eb9b6d1430c8b8a637314eae9084989 Mon Sep 17 00:00:00 2001 From: Thomas Hu Date: Wed, 12 Aug 2020 08:47:37 -0400 Subject: [PATCH 1/2] Remove flaky test and update README --- README.md | 7 ++++--- test/upload.test.js | 27 --------------------------- 2 files changed, 4 insertions(+), 30 deletions(-) diff --git a/README.md b/README.md index 234d3967..78932771 100644 --- a/README.md +++ b/README.md @@ -1,8 +1,8 @@ # Codecov NodeJS Uploader [![NPM version][npm-image]][npm-url] +[![Build Status][github-actions-image]][github-actions-url] [![Build Status][travis-image]][travis-url] -[![Build Status][appveyor-image]][appveyor-url] [![codecov.io](https://codecov.io/github/codecov/codecov-node/coverage.svg?branch=master)](https://codecov.io/github/codecov/codecov-node?branch=master) [![Dependency Status][depstat-image]][depstat-url] [![Dev Dependency Status][devdepstat-image]][devdepstat-url] @@ -68,10 +68,11 @@ istanbul cover test.js ./node_modules/.bin/codecov ``` +[appveyor-url]: https://ci.appveyor.com/project/eddiemoore/codecov-node-s38o6/branch/master +[github-actions-image]: https://github.com/codecov/codecov-node/workflows/Node%20CI/badge.svg +[github-actions-url]: https://github.com/codecov/codecov-node/actions?query=workflow%3A%22Node+CI%22 [travis-image]: https://travis-ci.org/codecov/codecov-node.svg?branch=master [travis-url]: https://travis-ci.org/codecov/codecov-node -[appveyor-image]: https://ci.appveyor.com/api/projects/status/ea1suiv0tprnq61l?svg=true -[appveyor-url]: https://ci.appveyor.com/project/eddiemoore/codecov-node/branch/master [npm-url]: https://npmjs.org/package/codecov [npm-image]: https://img.shields.io/npm/v/codecov.svg [depstat-url]: https://david-dm.org/codecov/codecov-node diff --git a/test/upload.test.js b/test/upload.test.js index be0ead06..b3376fab 100644 --- a/test/upload.test.js +++ b/test/upload.test.js @@ -67,31 +67,4 @@ describe('Codecov', function() { } ) }) - - it("upload v2 doesn't throw runtime error", function(done) { - expect( - codecov.sendToCodecovV2.bind( - null, - 'https://codecov.io', - { - token: 'f881216b-b5c0-4eb1-8f21-b51887d1d506', - commit: 'c739768fcac68144a3a6d82305b9c4106934d31a', - branch: 'master', - }, - 'testing node-' + codecov.version, - function(body) { - expect(body).toContain( - 'https://codecov.io/github/codecov/ci-repo/commit/c739768fcac68144a3a6d82305b9c4106934d31a' - ) - done() - }, - function(errCode, errMsg) { - if (offlineErrors.indexOf(errCode) !== -1) { - done() - } - throw new Error(errMsg) - } - ) - ).not.toThrow() - }) }) From 4daaf53d517aa54dc1c0672a4473602471ee6c96 Mon Sep 17 00:00:00 2001 From: Thomas Hu Date: Wed, 12 Aug 2020 09:02:48 -0400 Subject: [PATCH 2/2] Use x64 for appveyor --- README.md | 2 +- appveyor.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 78932771..ce8e47b8 100644 --- a/README.md +++ b/README.md @@ -1,9 +1,9 @@ # Codecov NodeJS Uploader +[![codecov.io](https://codecov.io/github/codecov/codecov-node/coverage.svg?branch=master)](https://codecov.io/github/codecov/codecov-node?branch=master) [![NPM version][npm-image]][npm-url] [![Build Status][github-actions-image]][github-actions-url] [![Build Status][travis-image]][travis-url] -[![codecov.io](https://codecov.io/github/codecov/codecov-node/coverage.svg?branch=master)](https://codecov.io/github/codecov/codecov-node?branch=master) [![Dependency Status][depstat-image]][depstat-url] [![Dev Dependency Status][devdepstat-image]][devdepstat-url] diff --git a/appveyor.yml b/appveyor.yml index d4753d59..9d21b095 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -12,7 +12,7 @@ init: - git config --global core.autocrlf true install: - - ps: Install-Product node $env:nodejs_version + - ps: Install-Product node $env:nodejs_version x64 - npm install test_script: