This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

assumption for CODEBUILD_SOURCE_VERSION is too strict #153

Open

dbollinger opened this issue Oct 11, 2019 · 0 comments

dbollinger commented Oct 11, 2019

The codebuild update here assumes CODEBUILD_SOURCE_VERSION is always the PR number: https://github.com/codecov/codecov-node/pull/135/files#diff-f9543833f7107b39b6ce133555c04e02R27

However, it can be a number of other options depending on build setup:

For GitHub, GitHub Enterprise, and Bitbucket it is the commit ID, branch name, or tag name associated with the version of the source code to be built.
Note
For a GitHub or GitHub Enterprise build that is triggered by a webhook pull request event, it is pr/pull-request-number.

https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-env-vars.html

kisaraofpern mentioned this issue

Verify source version before parsing PR #172

Merged

thomasrockhu self-assigned this

thomasrockhu removed their assignment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.