From 837e8bf8e7ae798046312a88475459f967307e42 Mon Sep 17 00:00:00 2001
From: Thomas Hu <tomhu1096@gmail.com>
Date: Thu, 20 Aug 2020 10:23:53 -0400
Subject: [PATCH] Create CHANGELOG and remove flaky v4 test

---
 CHANGELOG.md        | 96 +++++++++++++++++++++++++++++++++++++++++++++
 README.md           | 28 -------------
 lib/codecov.js      |  6 +--
 test/upload.test.js | 27 -------------
 4 files changed, 99 insertions(+), 58 deletions(-)
 create mode 100644 CHANGELOG.md

diff --git a/CHANGELOG.md b/CHANGELOG.md
new file mode 100644
index 00000000..4c4daef6
--- /dev/null
+++ b/CHANGELOG.md
@@ -0,0 +1,96 @@
+### 3.7.2
+
+- Fix issue with network and file finding
+
+### 3.7.1
+
+- Move to execFileSync and security fixes
+
+### 3.7.0
+
+- Remove the X-Amz-Acl: public-read header
+
+### 3.6.4
+
+- Fix Cirrus CI
+
+### 3.6.3
+
+- Fix for AWS Codebuild & package updates
+
+### 3.6.2
+
+- Command line args sanitized fix
+
+### 3.6.1
+
+- Fix for Semaphore
+
+### 3.6.0
+
+- Added AWS CodeBuild and Semaphore2
+
+### 3.5.0
+
+- Added TeamCity support
+
+### 3.4.0
+
+- Added Heroku CI support
+
+### 3.3.0
+
+- Added pipe with `--pipe`, `-l`
+
+### 3.2.0
+
+- Added azure pipelines
+  .
+
+### 3.1.0
+
+- Custom yaml file. Allow codecov token from yml file.
+
+### 3.0.4
+
+- Security fixes
+
+### 3.0.3
+
+- Support non-git/hg root dirs
+
+### 3.0.2
+
+- Security fixes
+
+### 3.0.1
+
+- Security fixes
+
+### 3.0.0
+
+- No longer supports node v0.12 because of new version of request
+
+### 2.3.0
+
+- Added support for Windows. Updated dependencies.
+
+### 2.2.0
+
+- Support for Jenkins Blue Ocean. Clean reports after upload. Fix for Gitlab.
+
+### 2.1.0
+
+- Flags supported http://docs.codecov.io/docs/flags
+
+### 2.0.2
+
+- Display correct version number in console.
+
+### 2.0.1
+
+- Publish as latest instead of next.
+
+### 2.0.0
+
+- No longer supports node v0.10 because of the execSync.
diff --git a/README.md b/README.md
index ce8e47b8..76572cec 100644
--- a/README.md
+++ b/README.md
@@ -91,31 +91,3 @@ nyc report --reporter=text-lcov > coverage.lcov
 ## Troubleshooting
 
 If you're seeing an **HTTP 400 error when uploading reports to S3**, make sure you've updated to at least version 3.7.0.
-
-## Change Log
-
-- v2.0.0 No longer supports node v0.10 because of the execSync.
-- v2.0.1 Publish as latest instead of next.
-- v2.0.2 Display correct version number in console.
-- v2.1.0 Flags supported http://docs.codecov.io/docs/flags
-- v2.2.0 Support for Jenkins Blue Ocean. Clean reports after upload. Fix for Gitlab.
-- v2.3.0 Added support for Windows. Updated dependencies.
-- v3.0.0 No longer supports node v0.12 because of new version of request
-- v3.0.1 Security fixes
-- v3.0.2 Security fixes
-- v3.0.3 Support non-git/hg root dirs
-- v3.0.4 Security fixes
-- v3.1.0 Custom yaml file. Allow codecov token from yml file.
-- v3.2.0 Added azure pipelines
-- v3.3.0 Added pipe with `--pipe`, `-l`
-- v3.4.0 Added Heroku CI support
-- v3.5.0 Added TeamCity support
-- v3.6.0 Added AWS CodeBuild and Semaphore2
-- v3.6.1 Fix for Semaphore
-- v3.6.2 Command line args sanitized fix
-- v3.6.3 Fix for AWS Codebuild & package updates
-- v3.6.4 Fix Cirrus CI
-- v3.7.0 Remove the X-Amz-Acl: public-read header
-- v3.7.1 Move to execFileSync and security fixes
-- v3.7.2 Fix issue with network and file finding
-  .
diff --git a/lib/codecov.js b/lib/codecov.js
index 29d38369..7f9f497e 100644
--- a/lib/codecov.js
+++ b/lib/codecov.js
@@ -179,7 +179,7 @@ var sendToCodecovV2 = function(
   )
 }
 
-var sendToCodecovV3 = function(
+var sendToCodecovV4 = function(
   codecov_endpoint,
   query,
   upload_body,
@@ -541,7 +541,7 @@ var upload = function(args, on_success, on_failure) {
       console.log('==> Uploading reports')
       var _upload
       if ((args.options.disable || '').split(',').indexOf('s3') === -1) {
-        _upload = sendToCodecovV3
+        _upload = sendToCodecovV4
       } else {
         _upload = sendToCodecovV2
       }
@@ -585,5 +585,5 @@ module.exports = {
   upload: upload,
   version: version,
   sendToCodecovV2: sendToCodecovV2,
-  sendToCodecovV3: sendToCodecovV3,
+  sendToCodecovV4: sendToCodecovV4,
 }
diff --git a/test/upload.test.js b/test/upload.test.js
index b3376fab..1f351ae5 100644
--- a/test/upload.test.js
+++ b/test/upload.test.js
@@ -40,31 +40,4 @@ describe('Codecov', function() {
       }
     )
   })
-
-  it('can get upload to v3', function(done) {
-    var self = this
-    jest.setTimeout(10000) // give this test extra time to run (default is 2000ms)
-    codecov.sendToCodecovV3(
-      'https://codecov.io',
-      {
-        token: 'f881216b-b5c0-4eb1-8f21-b51887d1d506',
-        commit: 'c739768fcac68144a3a6d82305b9c4106934d31a',
-        branch: 'master',
-      },
-      'testing node-' + codecov.version,
-      function(body) {
-        expect(body).toContain(
-          'https://codecov.io/github/codecov/ci-repo/commit/c739768fcac68144a3a6d82305b9c4106934d31a'
-        )
-        done()
-      },
-      function(errCode, errMsg) {
-        if (offlineErrors.indexOf(errCode) !== -1) {
-          self.skip() // offline - we can not test upload
-          return
-        }
-        throw new Error(errMsg)
-      }
-    )
-  })
 })