Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use import to destructure package.json #432

Merged
merged 5 commits into from Jul 21, 2021

Conversation

RA80533
Copy link
Contributor

@RA80533 RA80533 commented Jul 20, 2021

Fixes #431

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #432 (37cfa1c) into master (eac41f1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #432   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files           3        3           
  Lines         113      113           
  Branches       34       34           
=======================================
  Hits          109      109           
  Misses          4        4           
Flag Coverage Δ
demo 85.71% <ø> (ø)
macos-latest 96.46% <100.00%> (ø)
script 97.97% <100.00%> (ø)
ubuntu-latest 96.46% <100.00%> (ø)
windows-latest 96.46% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/buildExec.ts 97.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac41f1...37cfa1c. Read the comment docs.

@RA80533 RA80533 changed the title (WIP) fix: use import to destructure package.json fix: use import to destructure package.json Jul 21, 2021
@RA80533 RA80533 marked this pull request as ready for review July 21, 2021 07:15
Copy link
Contributor

@thomasrockhu thomasrockhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RA80533 !

@thomasrockhu thomasrockhu merged commit 3375d62 into codecov:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

index.js needs to be regenerated due to changes made in package.json
2 participants