Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite pull_request_target pr number #264

Merged
merged 1 commit into from Apr 2, 2021
Merged

Overwrite pull_request_target pr number #264

merged 1 commit into from Apr 2, 2021

Conversation

thomasrockhu
Copy link
Contributor

Fixes #155

This PR addresses the issue with pull_request_target events and Codecov pulling the wrong PR number. The Action will now force the value to the bash uploader.

@thomasrockhu thomasrockhu requested a review from a team March 29, 2021 22:16
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #264 (d9a1bbc) into master (fcebab0) will increase coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   97.10%   97.14%   +0.04%     
==========================================
  Files           3        3              
  Lines         138      140       +2     
  Branches       42       43       +1     
==========================================
+ Hits          134      136       +2     
  Misses          4        4              
Flag Coverage Δ
demo 87.50% <ø> (ø)
script 98.38% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/buildExec.ts 98.38% <50.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcebab0...d9a1bbc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action fails to upload when using pull_request_target on GitHub
2 participants