Overwrite the commit on pull_request* events #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
+ Coverage 97.67% 97.77% +0.10%
==========================================
Files 3 3
Lines 129 135 +6
Branches 38 41 +3
==========================================
+ Hits 126 132 +6
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
thomasrockhu
changed the title
drazisil-codecov
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
Can you please edit the PR description explaining what these changes do? I think that would be a good process to start as some of these changes can be quite confusing. Would be very helpful for both reviewers and other viewers o this PR. (also helps when searching) :)
Merged
This was referenced Mar 9, 2021
github-actions(deps): bump codecov/codecov-action from v1.2.1 to v1.2.2
mimmi20/browser-detector#524
Merged
This was referenced Mar 17, 2021
Closed
github-actions bot
pushed a commit
to ros-tooling/libstatistics_collector
that referenced
this pull request
Mar 31, 2021
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.2.1 to v1.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p> <blockquote> <h2>v1.3.1</h2> <h2>1.3.1</h2> <h3>Fixes</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/253">#253</a> Add <code>network_filter</code> to action manifest</li> </ul> <h2>v1.3.0</h2> <h2>1.3.0</h2> <h3>Features</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/252">#252</a> Add "network_filter" input</li> </ul> <h2>v1.2.2</h2> <h3>Fixes</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/241">#241</a> pass root_dir using proper bash arg</li> <li><a href="https://github.com/codecov/codecov-action/issues/244">#244</a> Overwrite the commit on pull_request* events</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md">codecov/codecov-action's changelog</a>.</em></p> <blockquote> <h2>1.3.1</h2> <h3>Fixes</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/253">#253</a> Add <code>network_filter</code> to action manifest</li> </ul> <h2>1.3.0</h2> <h3>Features</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/252">#252</a> Add "network_filter" input</li> </ul> <h2>1.2.2</h2> <h3>Fixes</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/241">#241</a> pass root_dir using proper bash arg</li> <li><a href="https://github.com/codecov/codecov-action/issues/244">#244</a> Overwrite the commit on pull_request* events</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/codecov/codecov-action/commit/fcebab03f26c7530a22baa63f06b3e0515f0c7cd"><code>fcebab0</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/253">#253</a> from codecov/1.3.1</li> <li><a href="https://github.com/codecov/codecov-action/commit/7ea3ba9ac075d6b603dc17b37e2984a5fda6843b"><code>7ea3ba9</code></a> Add network_filter to manifest</li> <li><a href="https://github.com/codecov/codecov-action/commit/6ed0d16b40c7d9a556bd123f0e7253be6ed081df"><code>6ed0d16</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/252">#252</a> from codecov/1.3.0</li> <li><a href="https://github.com/codecov/codecov-action/commit/79a0ba12c830bcfe66179a421069b588cb277952"><code>79a0ba1</code></a> Add network filter parameter</li> <li><a href="https://github.com/codecov/codecov-action/commit/1f8f3abcccf7960749744fd13547965f0e7d1bdd"><code>1f8f3ab</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/247">#247</a> from codecov/1.2.2</li> <li><a href="https://github.com/codecov/codecov-action/commit/763298c6f68b6b2d4191362e8da948ad180b4299"><code>763298c</code></a> Update CHANGELOG.md</li> <li><a href="https://github.com/codecov/codecov-action/commit/3207ad4e6013c331c40ac815c772d6e9714f5f77"><code>3207ad4</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/241">#241</a> from jeffkenney/fix-root-dir-arg</li> <li><a href="https://github.com/codecov/codecov-action/commit/ab3cfafc5bac7280958384264e1b954433cce9a7"><code>ab3cfaf</code></a> Bump to 1.2.2</li> <li><a href="https://github.com/codecov/codecov-action/commit/b708b7e81f3f8e04728cc8e1b1ad83735f01101f"><code>b708b7e</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/244">#244</a> from codecov/override-fetch-depth</li> <li><a href="https://github.com/codecov/codecov-action/commit/65f43cece2c52d3e87256602f328dc0cdd5ef4df"><code>65f43ce</code></a> actually</li> <li>Additional commits viewable in <a href="https://github.com/codecov/codecov-action/compare/v1.2.1...fcebab03f26c7530a22baa63f06b3e0515f0c7cd">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
github-actions bot
pushed a commit
to ros-tooling/launch_ros_sandbox
that referenced
this pull request
Mar 31, 2021
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.2.1 to v1.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p> <blockquote> <h2>v1.3.1</h2> <h2>1.3.1</h2> <h3>Fixes</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/253">#253</a> Add <code>network_filter</code> to action manifest</li> </ul> <h2>v1.3.0</h2> <h2>1.3.0</h2> <h3>Features</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/252">#252</a> Add "network_filter" input</li> </ul> <h2>v1.2.2</h2> <h3>Fixes</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/241">#241</a> pass root_dir using proper bash arg</li> <li><a href="https://github.com/codecov/codecov-action/issues/244">#244</a> Overwrite the commit on pull_request* events</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md">codecov/codecov-action's changelog</a>.</em></p> <blockquote> <h2>1.3.1</h2> <h3>Fixes</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/253">#253</a> Add <code>network_filter</code> to action manifest</li> </ul> <h2>1.3.0</h2> <h3>Features</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/252">#252</a> Add "network_filter" input</li> </ul> <h2>1.2.2</h2> <h3>Fixes</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/241">#241</a> pass root_dir using proper bash arg</li> <li><a href="https://github.com/codecov/codecov-action/issues/244">#244</a> Overwrite the commit on pull_request* events</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/codecov/codecov-action/commit/fcebab03f26c7530a22baa63f06b3e0515f0c7cd"><code>fcebab0</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/253">#253</a> from codecov/1.3.1</li> <li><a href="https://github.com/codecov/codecov-action/commit/7ea3ba9ac075d6b603dc17b37e2984a5fda6843b"><code>7ea3ba9</code></a> Add network_filter to manifest</li> <li><a href="https://github.com/codecov/codecov-action/commit/6ed0d16b40c7d9a556bd123f0e7253be6ed081df"><code>6ed0d16</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/252">#252</a> from codecov/1.3.0</li> <li><a href="https://github.com/codecov/codecov-action/commit/79a0ba12c830bcfe66179a421069b588cb277952"><code>79a0ba1</code></a> Add network filter parameter</li> <li><a href="https://github.com/codecov/codecov-action/commit/1f8f3abcccf7960749744fd13547965f0e7d1bdd"><code>1f8f3ab</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/247">#247</a> from codecov/1.2.2</li> <li><a href="https://github.com/codecov/codecov-action/commit/763298c6f68b6b2d4191362e8da948ad180b4299"><code>763298c</code></a> Update CHANGELOG.md</li> <li><a href="https://github.com/codecov/codecov-action/commit/3207ad4e6013c331c40ac815c772d6e9714f5f77"><code>3207ad4</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/241">#241</a> from jeffkenney/fix-root-dir-arg</li> <li><a href="https://github.com/codecov/codecov-action/commit/ab3cfafc5bac7280958384264e1b954433cce9a7"><code>ab3cfaf</code></a> Bump to 1.2.2</li> <li><a href="https://github.com/codecov/codecov-action/commit/b708b7e81f3f8e04728cc8e1b1ad83735f01101f"><code>b708b7e</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/244">#244</a> from codecov/override-fetch-depth</li> <li><a href="https://github.com/codecov/codecov-action/commit/65f43cece2c52d3e87256602f328dc0cdd5ef4df"><code>65f43ce</code></a> actually</li> <li>Additional commits viewable in <a href="https://github.com/codecov/codecov-action/compare/v1.2.1...fcebab03f26c7530a22baa63f06b3e0515f0c7cd">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
pull_request*events (pull_request,pull_request_target) using theactions/checkoutstep, GitHub Actions creates a detached HEAD SHA. This SHA is what gets sent to Codecov as opposed to the true HEAD SHA. The change ensures that the underlying uploader receives the correct SHA based on the GitHub context.This change will allow for usage of this Action without adding
fetch-depthto thecheckoutstep by overwriting the detached SHA with the HEAD SHA