You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In python-trio/trio#2951 we're trying to update to codecov-action@v4, and among other things we noticed a drop in coverage that seems to be due to our exclude_lines setting in pyproject.toml not being respected.
@jakkdl thanks for writing in. Was this a problem before updating to v4? IOW, was the exclude_lines in pyproject.toml being honored on v3 (and still being honored)?
Yeah it's working perfectly fine on v3, hence the drop in coverage when upgrading to v4 (because those lines are no longer excluded and are now seen as "missed").
In python-trio/trio#2951 we're trying to update to codecov-action@v4, and among other things we noticed a drop in coverage that seems to be due to our
exclude_lines
setting inpyproject.toml
not being respected.https://github.com/CoolCat467/trio/blob/c806b2056d6c39ee3399eadccb757874ca593f9f/pyproject.toml#L261-L282
ignores, among other things,
if TYPE_CHECKING.*:
andraise NotImplementedError
, but looking at a file such as https://app.codecov.io/gh/python-trio/trio/pull/2951/blob/src/trio/_socket.py we can see lines matching those are marked as misses.The text was updated successfully, but these errors were encountered: