Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unregistering servers using trash icon button not working #1987

Closed
pobodysnerfect opened this issue Feb 8, 2022 · 2 comments
Closed

unregistering servers using trash icon button not working #1987

pobodysnerfect opened this issue Feb 8, 2022 · 2 comments
Labels

Comments

@pobodysnerfect
Copy link

pobodysnerfect commented Feb 8, 2022

I'm currently running spring boot 2.6.2, and spring boot admin 2.6.2, and all the clients that are registering with the server are using spring boot admin client 1.5.2. I realize this isn't the recommended setup (we will be updating our services to the latest spring boot in time), but its unclear to me if this bug is related to that or not.

to reproduce, open up the instances and click on the trash icon:

Screen Shot 2022-02-08 at 12 16 32 PM

Nothing happens, and I get this stack trace in the console:

Axios.js:40 Uncaught (in promise) Error: Provided config url is not valid
at l.request (Axios.js:40:11)
at l.r.forEach.l. [as delete] (Axios.js:136:17)
at Function.delete (bind.js:9:15)
at t. (instance.js:55:23)
at l (runtime.js:63:40)
at Generator._invoke (runtime.js:294:22)
at Generator.next (runtime.js:119:21)
at r (asyncToGenerator.js:3:20)
at s (asyncToGenerator.js:25:9)
at asyncToGenerator.js:32:7

It seems like its trying to call this:

https://github.com/codecentric/spring-boot-admin/blob/master/spring-boot-admin-server-ui/src/main/frontend/services/instance.js#L55

but its failing because axios isn't configured. I also noticed that the registration source is "http-api", which seems to suggest unregistering isn't possible:

https://github.com/codecentric/spring-boot-admin/blob/master/spring-boot-admin-server-ui/src/main/frontend/services/instance.js#L51

but that would definitely be useful for us.

Expected: the trash icon should work and it should unregister the server
Actual: nothing happens and i get an exception in the console.

@chrisdev0
Copy link

Perhaps related to axios/axios#4407?

@erikpetzold
Copy link
Member

Should be fixed with new axios version, we just merged #1994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants