Issue #1633 Possibility to disable SBA server side by property #1672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1672 +/- ##
============================================
+ Coverage 83.69% 83.72% +0.02%
- Complexity 1203 1208 +5
============================================
Files 151 152 +1
Lines 3514 3526 +12
Branches 251 253 +2
============================================
+ Hits 2941 2952 +11
- Misses 443 444 +1
Partials 130 130
Continue to review full report at Codecov.
|
SteKoe
requested changes
Mar 26, 2021
|
|
||
| if (!serverProperties.getServer().isEnabled()) { | ||
| return ConditionOutcome | ||
| .noMatch("Spring Boot Server is disabled, because 'spring.boot.admin.client.enabled' is false."); |
There was a problem hiding this comment.
Shouldn't this be spring.boot.admin.server.enabled in the noMatch string?
| @@ -52,7 +56,7 @@ In addition when the reverse proxy terminates the https connection, it may be ne | |||
|
|
|||
| | spring.boot.admin.probed-endpoints | |||
| | For Spring Boot 1.x client applications SBA probes for the specified endpoints using an OPTIONS request. | |||
| If the path differs from the id you can specify this as id:path (e.g. health:ping).. | |||
| If the path differs from the id you can specify this as id:path (e.g. health:ping).. | |||
There was a problem hiding this comment.
This change is not related to the PR, right? Can you please revert to removing the spaces?
Issue #1633 Fix noMatch message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.