Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency highlight.js to 10.4.1 [security] #1650

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 3, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change
highlight.js 9.18.3 -> 10.4.1

GitHub Vulnerability Alerts

GHSA-7wwv-vh3v-89cq

Impact: Potential ReDOS vulnerabilities (exponential and polynomial RegEx backtracking)

oswasp:

The Regular expression Denial of Service (ReDoS) is a Denial of Service attack, that exploits the fact that most Regular Expression implementations may reach extreme situations that cause them to work very slowly (exponentially related to input size). An attacker can then cause a program using a Regular Expression to enter these extreme situations and then hang for a very long time.

If are you are using Highlight.js to highlight user-provided data you are possibly vulnerable. On the client-side (in a browser or Electron environment) risks could include lengthy freezes or crashes... On the server-side infinite freezes could occur... effectively preventing users from accessing your app or service (ie, Denial of Service).

This is an issue with grammars shipped with the parser (and potentially 3rd party grammars also), not the parser itself. If you are using Highlight.js with any of the following grammars you are vulnerable. If you are using highlightAuto to detect the language (and have any of these grammars registered) you are vulnerable.

All versions prior to 10.4.1 are vulnerable, including version 9.18.5.

Grammars with exponential backtracking issues:

  • c-like (c, cpp, arduino)
  • handlebars (htmlbars)
  • gams
  • perl
  • jboss-cli
  • r
  • erlang-repl
  • powershell
  • routeros
  • livescript (10.4.0 and 9.18.5 included this fix)
  • javascript & typescript (10.4.0 included partial fixes)

And of course any aliases of those languages have the same issue. ie: hpp is no safer than cpp.

Grammars with polynomial backtracking issues:

  • kotlin
  • gcode
  • d
  • aspectj
  • moonscript
  • coffeescript/livescript
  • csharp
  • scilab
  • crystal
  • elixir
  • basic
  • ebnf
  • ruby
  • fortran/irpf90
  • livecodeserver
  • yaml
  • x86asm
  • dsconfig
  • markdown
  • ruleslanguage
  • xquery
  • sqf

And again: any aliases of those languages have the same issue. ie: ruby and rb share the same ruby issues.

Patches

  • Version 10.4.1 resolves these vulnerabilities. Please upgrade.

Workarounds / Mitigations

  • Discontinue use the affected grammars. (or perhaps use only those with poly vs exponential issues)
  • Attempt cherry-picking the grammar fixes into older versions...
  • Attempt using newer CDN versions of any affected languages. (ie using an older CDN version of the library with newer CDN grammars). Your mileage may vary.

References

For more information

If you have any questions or comments about this advisory:


Configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

Sorry, something went wrong.

@renovate renovate bot force-pushed the renovate/npm-highlight.js-vulnerability branch from 97e27e6 to eaf8211 Compare April 9, 2021 15:16
@renovate renovate bot changed the title chore(deps): update dependency highlight.js to 10.4.1 [security] chore(deps): update dependency highlight.js to 10.4.1 [security] - autoclosed May 26, 2021
@renovate renovate bot closed this May 26, 2021
@renovate renovate bot deleted the renovate/npm-highlight.js-vulnerability branch May 26, 2021 20:15
@renovate renovate bot changed the title chore(deps): update dependency highlight.js to 10.4.1 [security] - autoclosed chore(deps): update dependency highlight.js to 10.4.1 [security] May 26, 2021
@renovate renovate bot reopened this May 26, 2021
@renovate renovate bot restored the renovate/npm-highlight.js-vulnerability branch May 26, 2021 21:42
@renovate renovate bot force-pushed the renovate/npm-highlight.js-vulnerability branch from eaf8211 to bda39f5 Compare May 26, 2021 21:47
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

Merging #1650 (bda39f5) into master (966daea) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1650      +/-   ##
============================================
+ Coverage     83.61%   83.64%   +0.02%     
- Complexity     1217     1218       +1     
============================================
  Files           153      153              
  Lines          3571     3571              
  Branches        253      253              
============================================
+ Hits           2986     2987       +1     
+ Misses          456      455       -1     
  Partials        129      129              
Impacted Files Coverage Δ
...dmin/server/eventstore/InstanceEventPublisher.java 100.00% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966daea...bda39f5. Read the comment docs.

@erikpetzold erikpetzold merged commit 19e1c7f into master Jul 2, 2021
@erikpetzold erikpetzold deleted the renovate/npm-highlight.js-vulnerability branch July 2, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants