Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #345

Open
code423n4 opened this issue May 4, 2023 · 4 comments
Open

QA Report #345

code423n4 opened this issue May 4, 2023 · 4 comments
Labels
bug Something isn't working edited-by-warden grade-a high quality report This report is of especially high quality Q-09 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels May 4, 2023
code423n4 added a commit that referenced this issue May 4, 2023
code423n4 added a commit that referenced this issue May 4, 2023
@c4-pre-sort
Copy link

0xSorryNotSorry marked the issue as high quality report

@c4-pre-sort c4-pre-sort added the high quality report This report is of especially high quality label May 9, 2023
@GalloDaSballo
Copy link

1 claimableUserDelayedWithdrawals does not take into account withdrawalDelayBlocks Low 1
L + 3

2 sharesToUnderlying and underlyingToShares functions marked as view but docs say they can make changes Low 2
R

3 slashQueuedWithdrawal and slashShares functions should emit an event Low 1
NC

4 Immutable state variables lack zero address checks Low 7
OOS
5 Adding a return statement when the function defines a named return variable is redundant NC 2
OOS

1L 1R 1NC +3

@c4-judge
Copy link
Contributor

c4-judge commented Jun 2, 2023

GalloDaSballo marked the issue as grade-b

@c4-judge
Copy link
Contributor

c4-judge commented Jun 2, 2023

GalloDaSballo marked the issue as grade-a

@C4-Staff C4-Staff added the Q-09 label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working edited-by-warden grade-a high quality report This report is of especially high quality Q-09 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

5 participants