Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #85

Open
code423n4 opened this issue Feb 16, 2022 · 3 comments
Open

QA Report #85

code423n4 opened this issue Feb 16, 2022 · 3 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

I. Missing comments

https://github.com/code-423n4/2022-02-aave-lens/blob/main/contracts/libraries/InteractionLogic.sol#L44

@param _profileIdByHandleHash.The other parameters have the relevant comments attached to them.Therefore, consider adding for the aforementioned as well.

II. Zero address checks

https://github.com/code-423n4/2022-02-aave-lens/blob/main/contracts/core/CollectNFT.sol#L29

https://github.com/code-423n4/2022-02-aave-lens/blob/main/contracts/core/FollowNFT.sol#L48

To prevent accidental deployment to the
zero address and the need to redeploy the contract,add a require statement within the constructor.

https://github.com/code-423n4/2022-02-aave-lens/blob/main/contracts/core/FollowNFT.sol#L69

Prevent tokenIds from being accounted.

@code423n4 code423n4 added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax bug Something isn't working labels Feb 16, 2022
code423n4 added a commit that referenced this issue Feb 16, 2022
@Zer0dot
Copy link
Collaborator

Zer0dot commented Mar 18, 2022

First point valid, second point not valid, the standard ERC721 internal minting function checks the recipient address against the zero address.

@Zer0dot
Copy link
Collaborator

Zer0dot commented Mar 18, 2022

First point, as mentioned, is valid, but this will be changed with the fix to #70

@Zer0dot
Copy link
Collaborator

Zer0dot commented Mar 18, 2022

Resolved in lens-protocol/core#69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

2 participants