QA Report #85
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
I. Missing comments
https://github.com/code-423n4/2022-02-aave-lens/blob/main/contracts/libraries/InteractionLogic.sol#L44
@param _profileIdByHandleHash.The other parameters have the relevant comments attached to them.Therefore, consider adding for the aforementioned as well.
II. Zero address checks
https://github.com/code-423n4/2022-02-aave-lens/blob/main/contracts/core/CollectNFT.sol#L29
https://github.com/code-423n4/2022-02-aave-lens/blob/main/contracts/core/FollowNFT.sol#L48
To prevent accidental deployment to the
zero address and the need to redeploy the contract,add a require statement within the constructor.
https://github.com/code-423n4/2022-02-aave-lens/blob/main/contracts/core/FollowNFT.sol#L69
Prevent tokenIds from being accounted.
The text was updated successfully, but these errors were encountered: