Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #54

Open
code423n4 opened this issue Feb 16, 2022 · 1 comment
Open

QA Report #54

code423n4 opened this issue Feb 16, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

2022-02-aave-lens

LensHub.sol

1 Check inputs if addresses are not empty for immutable variables in the constructor.

if (followNFTImpl == address(0) || collectNFTImpl == address(0)
revert Errors.EmptyInputAdress();

https://github.com/code-423n4/2022-02-aave-lens/blob/main/contracts/core/LensHub.sol#L57-L60
@code423n4 code423n4 added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax bug Something isn't working labels Feb 16, 2022
code423n4 added a commit that referenced this issue Feb 16, 2022
@code423n4
kenta issue #54
da4fa1b
@Zer0dot
Copy link
Collaborator

Zer0dot commented Mar 24, 2022

Included in lens-protocol/core#80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zer0dot @code423n4