Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add metamorphic CPU work granter #3561

Open
RaduBerinde opened this issue Apr 27, 2024 · 1 comment
Open

meta: add metamorphic CPU work granter #3561

RaduBerinde opened this issue Apr 27, 2024 · 1 comment
Assignees
Projects

Comments

@RaduBerinde
Copy link
Member

The default CPU work granter never permits extra work, leaving the relevant code paths untested. The metamorphic test should add its own implementation, and have an associated test config option (e.g. probability that it permits extra work).

@RaduBerinde RaduBerinde self-assigned this Apr 27, 2024
@RaduBerinde RaduBerinde added this to Incoming in Storage via automation Apr 27, 2024
@RaduBerinde
Copy link
Member Author

Ah, I see this is only used when writing tables during compaction, and we have a separate ForceWriterParallelism option to bypass it. So we are testing both paths. Still, it would be cleaner and more powerful to use an implementation instead of an extra flag.

@RaduBerinde RaduBerinde moved this from Incoming to Backlog in Storage Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Storage
  
Backlog
Development

No branches or pull requests

1 participant