Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: limit EFOS sstable pinning to files overlapping bounds #3500

Open
jbowens opened this issue Apr 10, 2024 · 0 comments
Open

db: limit EFOS sstable pinning to files overlapping bounds #3500

jbowens opened this issue Apr 10, 2024 · 0 comments

Comments

@jbowens
Copy link
Collaborator

jbowens commented Apr 10, 2024

Eventually file-only snapshots suffer additional space amplification by pinning a readState/manifest.Version until closed. This prevents any sstables in the version from being deleted. Since an EFOS indicates the bounds that it requires consistency over, we can avoid pinning sstables outside those bounds.

@jbowens jbowens added this to Incoming in Storage via automation Apr 10, 2024
jbowens added a commit to jbowens/cockroach that referenced this issue Apr 10, 2024
Add a new timeseries metric that provides visibility into the volume of data
that exists in sstables that are not part of the most recent version of the
LSM.

Epic: none
Informs cockroachdb#121935.
Informs cockroachdb#122139.
Informs cockroachdb/pebble#3500.
Close cockroachdb#122110.
Release note (ops change): Adds a new timeseries metric
storage.sstable.zombie.bytes.
craig bot pushed a commit to cockroachdb/cockroach that referenced this issue Apr 11, 2024
122152: kvserver: add storage.sstable.zombie.bytes metric r=RaduBerinde a=jbowens

Add a new timeseries metric that provides visibility into the volume of data that exists in sstables that are not part of the most recent version of the LSM.

Epic: none
Informs #121935.
Informs #122139.
Informs cockroachdb/pebble#3500.
Close #122110.
Release note (ops change): Adds a new timeseries metric storage.sstable.zombie.bytes.

Co-authored-by: Jackson Owens <jackson@cockroachlabs.com>
blathers-crl bot pushed a commit to cockroachdb/cockroach that referenced this issue Apr 11, 2024
Add a new timeseries metric that provides visibility into the volume of data
that exists in sstables that are not part of the most recent version of the
LSM.

Epic: none
Informs #121935.
Informs #122139.
Informs cockroachdb/pebble#3500.
Close #122110.
Release note (ops change): Adds a new timeseries metric
storage.sstable.zombie.bytes.
@nicktrav nicktrav moved this from Incoming to 24.2 candidates in Storage Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Storage
  
24.2 candidates
Development

No branches or pull requests

1 participant