Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sstable: error out when opening empty ssts #3409

Open
RaduBerinde opened this issue Mar 14, 2024 · 1 comment
Open

sstable: error out when opening empty ssts #3409

RaduBerinde opened this issue Mar 14, 2024 · 1 comment

Comments

@RaduBerinde
Copy link
Member

I ran into a problem with SeekGE on an empty sst sometimes panicking with invalidated blockIter used. A few details in the (private) thread:

https://cockroachlabs.slack.com/archives/CAC6K3SLU/p1706130530093809?thread_ts=1706036242.466479&cid=CAC6K3SLU

We should make sure writing and using empty ssts works, because it's a surprising and subtle failure mode. In some corner cases (see #3406), we might end up writing an empty sst.

@RaduBerinde RaduBerinde self-assigned this Mar 14, 2024
@RaduBerinde RaduBerinde added this to Incoming in Storage via automation Mar 14, 2024
@itsbilal itsbilal moved this from Incoming to Backlog in Storage Mar 19, 2024
@RaduBerinde RaduBerinde removed their assignment May 23, 2024
@RaduBerinde
Copy link
Member Author

I don't think it makes sense to ever write out empty physical ssts. We should add a check when we open one that it isn't empty, to avoid the panicky failure mode.

@RaduBerinde RaduBerinde changed the title sstable: support empty ssts sstable: error out when opening empty ssts May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Storage
  
Backlog
Development

No branches or pull requests

1 participant