metamorphic: convert some DB.Deletes into DB.SingleDeletes #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adjusts the metamorphic test to increase coverage of single deletes. Randomized configurations will, at runtime, consider perofmring a SingleDelete instead of a Delete on a subset of delete operations performed on (*pebble.DB) objects. These instances create a short-lived iterator, seek to the key and use pebble.CanDeterministicallySingleDelete to determine whether a single delete should be equivalent to a delete. If it should be, a SingleDelete is run instead. Closes cockroachdb#3108.
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts the metamorphic test to increase coverage of single deletes. Randomized configurations will, at runtime, consider performing a SingleDelete instead of a Delete on a subset of delete operations performed on (*pebble.DB) objects. These instances create a short-lived iterator, seek to the key and use pebble.CanDeterministicallySingleDelete to determine whether a single delete should be equivalent to a delete. If it should be, a SingleDelete is written instead.
Closes #3108.