Feedback: Session Variables - does not mention disable_changefeed_replication

[hand-crdb]

Steven Hand (hand-crdb) commented:

Page: https://cockroachlabs.com/docs/v24.1/session-variables.html

What is the reason for your feedback?

[X] Missing the information I need

[ ] Too complicated

[ ] Out of date

[ ] Something is broken

[ ] Other

Additional details

This page does not describe the disable_changefeed_replication session variable, which is mentioned at the following page:

What's New in v24.1

That page says:

The new boolean changefeed option ignore_disable_changefeed_replication, when set to true, prevents the changefeed from filtering events even if CDC filtering is configured via the disable_changefeed_replication session variable, sql.ttl.changefeed_replication.disabled cluster setting, or the ttl_disable_changefeed_replication table storage parameter. #120255

Jira Issue: DOC-10119

[exalate-issue-sync]

Shannon Bradshaw (shannonbradshaw) commented:
Kathryn May assigning to you just to make sure we’ve addressed this in the 24.1 release notes.

cc: Michael Lewis

[exalate-issue-sync]

Kathryn May (kathancox) commented:
That session variable is listed on the session variable page. And there is further documentation here: https://www.cockroachlabs.com/docs/dev/changefeed-messages#filtering-changefeed-messages

This merged recently, so I think maybe this might have just been missed — unless I’m misunderstanding the ask here.

Checking the date this issue opened, I think we are safe to close the issue here. Feel free to reopen if I have missed something. PR for details: #18496

[exalate-issue-sync]

Michael Lewis (mikeCRL) commented:
We happen to make reference to this in an item I have in the Key Cluster Setting Changes, copied from a release note from one of the 24.1.0 testing releases:

{{- The new boolean changefeed option ignore_disable_changefeed_replication, when set to true, prevents the changefeed from filtering events even if CDC filtering is configured via the disable_changefeed_replication session variable, sql.ttl.changefeed_replication.disabled cluster setting, or the ttl_disable_changefeed_replication table storage parameter. [#120255][#120255]}}

That said, I’m logging a task to consider whether we want to aggregate changes to session vars in a similar way to what we’ve been doing for cluster settings.