Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alter column/PK data types says it's in preview? #18389

Open
glennfawcett opened this issue Mar 15, 2024 · 2 comments
Open

alter column/PK data types says it's in preview? #18389

glennfawcett opened this issue Mar 15, 2024 · 2 comments
Assignees

Comments

@glennfawcett
Copy link

glennfawcett commented Mar 15, 2024

Glenn Fawcett (glennfawcett) commented:

https://www.cockroachlabs.com/docs/stable/alter-table#alter-column-data-types

^^^--- Says that altering a column size is in "preview". I believe this has been working for a while now. This is a ping to review page.

root@localhost:26257/defaultdb> create table small_id(id int4 primary key);
CREATE TABLE

Time: 22ms total (execution 21ms / network 0ms)

root@localhost:26257/defaultdb> insert into small_id values (1),(2);
INSERT 0 2

Time: 18ms total (execution 18ms / network 0ms)

root@localhost:26257/defaultdb> insert into small_id values (11111111111);
ERROR: integer out of range for type int4
SQLSTATE: 22003
root@localhost:26257/defaultdb> alter table small_id alter column id set data type int8;
ALTER TABLE

Time: 155ms total (execution 155ms / network 0ms)

root@localhost:26257/defaultdb> insert into small_id values (11111111111);
INSERT 0 1

Time: 8ms total (execution 8ms / network 0ms)

root@localhost:26257/defaultdb>

Jira Issue: DOC-9890

Copy link

Shannon Bradshaw (shannonbradshaw) commented:
Ryan Kuo can you take a quick look at this and either fix and close or comment as to why we should leave the page as is?

Copy link

Ryan Kuo (taroface) commented:
Hi Glenn Fawcett, thanks for filing. Dikshant Adhikari confirmed that this is still meant to be in Preview. I noticed that the session var associated with this feature hadn’t been documented, so I opened a PR to address that. This issue will be closed once that PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants